From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Thomas Huth <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets
Date: Fri, 8 Nov 2019 18:38:11 +0100 [thread overview]
Message-ID: <288753f3-872e-8eca-1f86-869ae6bf5380@redhat.com> (raw)
In-Reply-To: <20191108114531.21518-2-philmd@redhat.com>
On 11/08/19 12:45, Philippe Mathieu-Daudé wrote:
> The EDK2 firmware blobs only target the X86/ARM architectures.
> Define the DECOMPRESS_EDK2_BLOBS variable and only decompress
> the blobs when the variable exists.
>
> Fixes: 536d2173b2b
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: new
> ---
> Makefile | 2 ++
> configure | 13 +++++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index aa9d1a42aa..3430eca532 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -480,7 +480,9 @@ $(SOFTMMU_ALL_RULES): $(chardev-obj-y)
> $(SOFTMMU_ALL_RULES): $(crypto-obj-y)
> $(SOFTMMU_ALL_RULES): $(io-obj-y)
> $(SOFTMMU_ALL_RULES): config-all-devices.mak
> +ifdef DECOMPRESS_EDK2_BLOBS
> $(SOFTMMU_ALL_RULES): $(edk2-decompressed)
> +endif
>
> .PHONY: $(TARGET_DIRS_RULES)
> # The $(TARGET_DIRS_RULES) are of the form SUBDIR/GOAL, so that
> diff --git a/configure b/configure
> index efe165edf9..9b322284c3 100755
> --- a/configure
> +++ b/configure
> @@ -427,6 +427,7 @@ softmmu="yes"
> linux_user="no"
> bsd_user="no"
> blobs="yes"
> +edk2_blobs="no"
> pkgversion=""
> pie=""
> qom_cast_debug="yes"
> @@ -2146,6 +2147,14 @@ case " $target_list " in
> ;;
> esac
>
> +for target in $target_list; do
> + case "$target" in
> + arm-softmmu | aarch64-softmmu | i386-softmmu | x86_64-softmmu)
> + edk2_blobs="yes"
> + ;;
> + esac
> +done
> +
> feature_not_found() {
> feature=$1
> remedy=$2
> @@ -7526,6 +7535,10 @@ if test "$libudev" != "no"; then
> echo "LIBUDEV_LIBS=$libudev_libs" >> $config_host_mak
> fi
>
> +if test "$edk2_blobs" = "yes" ; then
> + echo "DECOMPRESS_EDK2_BLOBS=y" >> $config_host_mak
> +fi
> +
> # use included Linux headers
> if test "$linux" = "yes" ; then
> mkdir -p linux-headers
>
Impressively surgical & simple.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thank you!
Laszlo
next prev parent reply other threads:[~2019-11-08 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 11:45 [PATCH v2 0/2] configure: Only decompress EDK2 blobs and check for bzip2 for X86/ARM Philippe Mathieu-Daudé
2019-11-08 11:45 ` [PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets Philippe Mathieu-Daudé
2019-11-08 11:47 ` Daniel P. Berrangé
2019-11-08 11:49 ` Philippe Mathieu-Daudé
2019-11-08 13:32 ` Wainer dos Santos Moschetta
2019-11-08 14:02 ` Luc Michel
2019-11-08 17:38 ` Laszlo Ersek [this message]
2019-11-08 11:45 ` [PATCH v2 2/2] configure: Check bzip2 is available Philippe Mathieu-Daudé
2019-11-08 11:48 ` Daniel P. Berrangé
2019-11-08 13:33 ` Wainer dos Santos Moschetta
2019-11-08 17:43 ` Laszlo Ersek
2019-11-11 13:38 ` Thomas Huth
2019-11-08 14:04 ` Luc Michel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288753f3-872e-8eca-1f86-869ae6bf5380@redhat.com \
--to=lersek@redhat.com \
--cc=berrange@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).