From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B309C3E8C5 for ; Sun, 29 Nov 2020 11:55:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB7DA206DF for ; Sun, 29 Nov 2020 11:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB7DA206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjLIQ-0007tL-9T for qemu-devel@archiver.kernel.org; Sun, 29 Nov 2020 06:55:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjLGa-0007PS-N5 for qemu-devel@nongnu.org; Sun, 29 Nov 2020 06:53:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:41502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjLGW-0006NA-5b for qemu-devel@nongnu.org; Sun, 29 Nov 2020 06:53:20 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0002BAC2E; Sun, 29 Nov 2020 11:53:12 +0000 (UTC) Subject: Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c To: Eduardo Habkost References: <20201126223218.31480-1-cfontana@suse.de> <20201126223218.31480-8-cfontana@suse.de> <20201127190424.GH2271382@habkost.net> <20201127204347.GI2271382@habkost.net> From: Claudio Fontana Message-ID: <297ed700-eedc-f182-2139-9776e6b9a913@suse.de> Date: Sun, 29 Nov 2020 12:53:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201127204347.GI2271382@habkost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jason Wang , qemu-devel@nongnu.org, Peter Xu , haxm-team@intel.com, Colin Xu , gengdongjiu@huawei.com, Olaf Hering , Stefano Stabellini , Bruce Rogers , "Emilio G . Cota" , Anthony Perard , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laurent Vivier , Thomas Huth , Richard Henderson , Cameron Esfahani , Dario Faggioli , Roman Bolshakov , Sunil Muthuswamy , Alex Bennee , Marcelo Tosatti , Wenchao Wang , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/27/20 9:43 PM, Eduardo Habkost wrote: > On Fri, Nov 27, 2020 at 08:47:00PM +0100, Claudio Fontana wrote: >> On 11/27/20 8:04 PM, Eduardo Habkost wrote: > [...] >>> Maybe we should rename CPUClass.synchronize_from_tb to >>> CPUClass.tcg_synchronize_from_tb? Maybe we should have a >> >> possibly, yes. >> >>> separate TCGCpuOperations struct to carry TCG-specific methods? >> >> >> interesting, will think about it. > > I'm working on it at: > https://gitlab.com/ehabkost/qemu/-/commits/work/tcg-cpu-ops > > Feel free to reuse it, if you want to do it before your series. > Otherwise, I can rebase it after your series is merged. > > I didn't touch do_interrupt(), because of the aarch64 weirdness. > Hi, yes it makes sense to separate more clearly I think what is tcg only among those operations, it is a bit tangent to my series in the sense that those methods need to be set one way or another, either in cc-> or in cc->tcg_ops, but yes, we could put those changes before or after the series, and I think they make sense. Ciao, Claudio