From: Andrea Bolognani <abologna@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Marc Zyngier <maz@kernel.org>, qemu-arm <qemu-arm@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>,
bijan.mottahedeh@oracle.com,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time
Date: Tue, 10 Dec 2019 15:21:02 +0100 [thread overview]
Message-ID: <29add42daba074ab5bdbd462b2d377115fec7c3c.camel@redhat.com> (raw)
In-Reply-To: <20191210133254.22vcpvr3eabcnthe@kamzik.brq.redhat.com>
On Tue, 2019-12-10 at 14:32 +0100, Andrew Jones wrote:
> After having done this git mining, it looks more and more like we should
> at least consider naming this feature 'kvm-no-adjvtime' and probably
> also change arm's default.
I agree with everything except the naming: why would
kvm-no-adjvtime=off vtime is adjusted (default)
kvm-no-adjvtime=on vtime is not adjusted
be better than
kvm-adjvtime=on vtime is adjusted (default)
kvm-adjvtime=off vtime is not adjusted
? Both offer the exact same amount of flexibility, but the latter has
the advantage of not introducing any unwieldy double negatives.
--
Andrea Bolognani / Red Hat / Virtualization
next prev parent reply other threads:[~2019-12-10 14:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:34 [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time Andrew Jones
2019-10-16 14:34 ` [PATCH v1 1/5] target/arm/kvm64: kvm64 cpus have timer registers Andrew Jones
2019-10-16 14:34 ` [PATCH v1 2/5] timer: arm: Introduce functions to get the host cntfrq Andrew Jones
2019-12-10 15:47 ` Peter Maydell
2019-12-10 16:41 ` Andrew Jones
2019-10-16 14:34 ` [PATCH v1 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime Andrew Jones
2019-12-10 15:54 ` Peter Maydell
2019-12-10 16:10 ` Andrew Jones
2019-10-16 14:34 ` [PATCH v1 4/5] tests/arm-cpu-features: Check feature default values Andrew Jones
2019-10-16 14:34 ` [PATCH v1 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property Andrew Jones
2019-10-17 21:17 ` [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time Masayoshi Mizuma
2019-10-18 12:02 ` Andrew Jones
2019-10-28 18:39 ` Masayoshi Mizuma
2019-12-06 15:22 ` Peter Maydell
2019-12-06 15:53 ` Andrew Jones
2019-12-10 9:51 ` Andrea Bolognani
2019-12-10 10:29 ` Peter Maydell
2019-12-10 11:05 ` Andrew Jones
2019-12-10 11:48 ` Peter Maydell
2019-12-10 13:32 ` Andrew Jones
2019-12-10 14:21 ` Andrea Bolognani [this message]
2019-12-10 14:33 ` Andrew Jones
2019-12-10 15:47 ` Andrea Bolognani
2019-12-10 16:08 ` Andrew Jones
2019-12-10 17:16 ` Andrea Bolognani
2019-12-10 15:45 ` Peter Maydell
2019-12-11 8:02 ` Guoheyi
2019-12-11 9:00 ` Andrew Jones
2019-12-11 13:50 ` Guoheyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29add42daba074ab5bdbd462b2d377115fec7c3c.camel@redhat.com \
--to=abologna@redhat.com \
--cc=bijan.mottahedeh@oracle.com \
--cc=drjones@redhat.com \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).