From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F676C2B9F4 for ; Fri, 18 Jun 2021 03:00:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B859361241 for ; Fri, 18 Jun 2021 03:00:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B859361241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lu4k8-0002R8-HV for qemu-devel@archiver.kernel.org; Thu, 17 Jun 2021 23:00:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu4j8-0001mw-5I for qemu-devel@nongnu.org; Thu, 17 Jun 2021 22:59:26 -0400 Received: from mga04.intel.com ([192.55.52.120]:13467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu4j5-0003Mx-89 for qemu-devel@nongnu.org; Thu, 17 Jun 2021 22:59:25 -0400 IronPort-SDR: VDWLFPuCwVdCt+nbJaykOFUDvcRsmKDW1N5fYCFTv5czZG40qoYYZR8JmgXWB5xujltrxkDEk1 mda12g7AxWSw== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="204656966" X-IronPort-AV: E=Sophos;i="5.83,281,1616482800"; d="scan'208";a="204656966" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 19:59:10 -0700 IronPort-SDR: QR/FX76iaCPoPQyRVIakcQYiJo6LnPDErmZ66hNa9T+k/nIXlsNPCcmEb5U5O6uNlRu9bwOm11 r9ugBA+HRxfQ== X-IronPort-AV: E=Sophos;i="5.83,281,1616482800"; d="scan'208";a="451242525" Received: from unknown (HELO [10.239.13.19]) ([10.239.13.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 19:59:08 -0700 Subject: Re: [PATCH v6 00/10] Fixed some bugs and optimized some codes for COLO From: "chen.zhang@intel.com" To: "Dr. David Alan Gilbert" References: <1617938456-315058-1-git-send-email-lei.rao@intel.com> <20210517214638.7519781b@gecko.fritz.box> <79a39d11ea124acbab097d17034ab6ff@intel.com> Message-ID: <2a750dfe-368f-5289-861d-f35ee639e82c@intel.com> Date: Fri, 18 Jun 2021 10:52:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <79a39d11ea124acbab097d17034ab6ff@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=192.55.52.120; envelope-from=chen.zhang@intel.com; helo=mga04.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.254, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Straub , "lizhijian@cn.fujitsu.com" , "quintela@redhat.com" , Jason Wang , "qemu-devel@nongnu.org" , "pbonzini@redhat.com" , "Rao, Lei" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/18/21 9:33 AM, Zhang, Chen wrote: > >> -----Original Message----- >> From: Lukas Straub >> Sent: Tuesday, May 18, 2021 3:47 AM >> To: Rao, Lei >> Cc: Zhang, Chen ; lizhijian@cn.fujitsu.com; >> jasowang@redhat.com; quintela@redhat.com; dgilbert@redhat.com; >> pbonzini@redhat.com; qemu-devel@nongnu.org >> Subject: Re: [PATCH v6 00/10] Fixed some bugs and optimized some codes >> for COLO >> >> On Thu, 8 Apr 2021 23:20:46 -0400 >> leirao wrote: >> >>> From: Rao, Lei >>> >>> Changes since v5: >>> --Replaced g_slice_new calls with g_slice_new0. >>> >>> Changes since v4: >>> --Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD in >> colo_bitmap_clear_dirty. >>> --Modify some minor issues about variable definition. >>> --Add some performance test data in the commit message. >>> >>> Changes since v3: >>> --Remove cpu_throttle_stop from mig_throttle_counter_reset. >>> >>> Changes since v2: >>> --Add a function named packet_new_nocopy. >>> --Continue to optimize the function of colo_flush_ram_cache. >>> >>> Changes since v1: >>> --Reset the state of the auto-converge counters at every checkpoint >> instead of directly disabling. >>> --Treat the filter_send function returning zero as a normal case. >>> >>> The series of patches include: >>> Fixed some bugs of qemu crash. >>> Optimized some code to reduce the time of checkpoint. >>> Remove some unnecessary code to improve COLO. >>> >>> Rao, Lei (10): >>> Remove some duplicate trace code. >>> Fix the qemu crash when guest shutdown during checkpoint >>> Optimize the function of filter_send >>> Remove migrate_set_block_enabled in checkpoint >>> Add a function named packet_new_nocopy for COLO. >>> Add the function of colo_compare_cleanup >>> Reset the auto-converge counter at every checkpoint. >>> Reduce the PVM stop time during Checkpoint >>> Add the function of colo_bitmap_clear_dirty >>> Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() >>> >>> migration/colo.c | 10 +++---- >>> migration/migration.c | 4 +++ >>> migration/ram.c | 83 >> +++++++++++++++++++++++++++++++++++++++++++++++++-- >>> migration/ram.h | 1 + >>> net/colo-compare.c | 25 +++++++--------- >>> net/colo-compare.h | 1 + >>> net/colo.c | 25 +++++++++++----- >>> net/colo.h | 1 + >>> net/filter-mirror.c | 8 ++--- >>> net/filter-rewriter.c | 3 +- >>> net/net.c | 4 +++ >>> softmmu/runstate.c | 1 + >>> 12 files changed, 129 insertions(+), 37 deletions(-) >>> >> I guess Zhang Chen can already take the network-related patches through his >> tree. > Sure, I will queue the patch 1-6 and 10. > Hi Dave, can you take the patch 7-9? Or do you think it's more convenient to take all series? Hi David, The 1-6 and 10 already been merged in upstream. Can you please pick up the rest of this series? By the way, If you have time, Lei submitted a new series of patch still need your comments, Thanks Chen > Thanks > Chen > >> Regards, >> Lukas Straub >> >> -- >