From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v1] virtio-mem-pci: force virtio version 1
Date: Mon, 27 Jul 2020 13:42:56 +0200 [thread overview]
Message-ID: <2a7d938b-cd30-4598-b151-d16dc0a2f46b@redhat.com> (raw)
In-Reply-To: <d9cfad16-5b62-483a-c049-4dbaec51cd3e@redhat.com>
On 22.07.20 16:22, David Hildenbrand wrote:
> On 08.07.20 16:36, David Hildenbrand wrote:
>> Let's force virtio version 1. While at it, use qdev_realize() to set
>> the parent bus and realize - like most other virtio-*-pci
>> implementations.
>>
>> Fixes: 0b9a2443a48b ("virtio-pci: Proxy for virtio-mem")
>> Cc: Cornelia Huck <cohuck@redhat.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> hw/virtio/virtio-mem-pci.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c
>> index 1a8e854123..831022aa86 100644
>> --- a/hw/virtio/virtio-mem-pci.c
>> +++ b/hw/virtio/virtio-mem-pci.c
>> @@ -21,8 +21,8 @@ static void virtio_mem_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
>> VirtIOMEMPCI *mem_pci = VIRTIO_MEM_PCI(vpci_dev);
>> DeviceState *vdev = DEVICE(&mem_pci->vdev);
>>
>> - qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
>> - object_property_set_bool(OBJECT(vdev), true, "realized", errp);
>> + virtio_pci_force_virtio_1(vpci_dev);
>> + qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
>> }
>>
>> static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr,
>>
>
> Ping @mst
>
With Conny's patches in, simple virtio-mem examples currently fail with
qemu-system-x86_64: -device
virtio-mem-pci,id=vm0,memdev=mem0,node=0,requested-size=300M: device is
modern-only, use disable-legacy=on
So we really want this in QEMU 5.1
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-07-27 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 14:36 [PATCH v1] virtio-mem-pci: force virtio version 1 David Hildenbrand
2020-07-08 14:58 ` Cornelia Huck
2020-07-22 14:22 ` David Hildenbrand
2020-07-27 11:42 ` David Hildenbrand [this message]
2020-07-27 11:49 ` Michael S. Tsirkin
2020-07-27 11:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a7d938b-cd30-4598-b151-d16dc0a2f46b@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).