From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v2 for-6.0?] hw/pci-host/gpex: Don't fault for unmapped parts of MMIO and PIO windows
Date: Tue, 20 Apr 2021 14:31:12 +0200 [thread overview]
Message-ID: <2ab20805-cd19-b628-00c3-e8b601c323db@amsat.org> (raw)
In-Reply-To: <CAK8P3a3zeYC0wiT2Or3RicPbVBY4TJCOTa6ZN3rT=e4XGR-eCA@mail.gmail.com>
On 4/20/21 2:26 PM, Arnd Bergmann wrote:
> On Tue, Apr 20, 2021 at 1:52 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> On 4/19/21 3:42 PM, Peter Maydell wrote:
>>>>
>>>> I suspect PCI-ISA bridges to provide an EISA bus.
>>>
>>> I'm not sure what you mean here -- there isn't an ISA bridge
>>> or an EISA bus involved here. This is purely about the behaviour
>>> of the memory window the PCI host controller exposes to the CPU
>>> (and in particular the window for when a PCI device's BAR is
>>> set to "IO" rather than "MMIO"), though we change both here.
>>
>> I guess I always interpreted the IO BAR were here to address ISA
>> backward compatibility. I don't know well PCI so I'll study it
>> more. Sorry for my confused comment.
>
> It is mostly for compatibility, but there are many layers of it:
>
> - PCI supports actual ISA/EISA/VLB/PCMCIA/LPC/PC104/... style
> devices behind a bridge, using I/O ports at their native address.
>
> - PCI devices themselves can have fixed I/O ports at well-known
> addresses, e.g. VGA or IDE/ATA adapters
>
> - PCI devices can behave like legacy devices using port I/O
> but use PCI resource assignment to pick an arbitrary port
> number outside of the legacy range
>
> - PCIe can support all of the above by virtue of being backwards
> compatible with PCI and allowing PCI buses behind bridges,
> though port I/O is deprecated here and often not supported at all
>
> The first two are very rare these days, but Linux still support them
> in order to run on old hardware, and any driver for these that
> assumes a hardcoded port number can crash the kernel if the
> PCI host bridge causes an asynchronous external abort or
> similar.
Thanks for the clarification and enumeration Arnd!
next prev parent reply other threads:[~2021-04-20 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 16:33 [PATCH v2 for-6.0?] hw/pci-host/gpex: Don't fault for unmapped parts of MMIO and PIO windows Peter Maydell
2021-03-25 17:01 ` Richard Henderson
2021-03-25 17:03 ` Michael S. Tsirkin
2021-03-25 18:14 ` Philippe Mathieu-Daudé
2021-04-19 13:42 ` Peter Maydell
2021-04-20 11:52 ` Philippe Mathieu-Daudé
2021-04-20 12:26 ` Arnd Bergmann
2021-04-20 12:31 ` Philippe Mathieu-Daudé [this message]
2021-04-20 10:24 ` Michael S. Tsirkin
2021-04-20 12:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab20805-cd19-b628-00c3-e8b601c323db@amsat.org \
--to=f4bug@amsat.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).