From: Max Reitz <mreitz@redhat.com>
To: Nir Soffer <nirsof@gmail.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Nir Soffer <nsoffer@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/2] Optimize alignment probing
Date: Tue, 27 Aug 2019 19:00:13 +0200 [thread overview]
Message-ID: <2b1dc4ab-f313-2420-7898-66d8ccddae24@redhat.com> (raw)
In-Reply-To: <20190827010528.8818-1-nsoffer@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 576 bytes --]
On 27.08.19 03:05, Nir Soffer wrote:
> When probing unallocated area on remote XFS filesystem we cannot detect request
> alignment and we fallback to safe value which may not be optimal. Avoid this
> fallback by always allocating the first block when creating a new image or
> resizing empty image.
>
> Tested with all formats:
>
> for fmt in raw bochs cloop parallels qcow qcow2 qed vdi vpc vhdx vmdk luks dmg; do
> ./check -$fmt
> done
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-08-27 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 1:05 [Qemu-devel] [PATCH v3 0/2] Optimize alignment probing Nir Soffer
2019-08-27 1:05 ` [Qemu-devel] [PATCH v3 1/2] block: posix: Always allocate the first block Nir Soffer
2019-08-27 16:58 ` Max Reitz
2019-08-27 17:10 ` Max Reitz
2019-08-27 1:05 ` [Qemu-devel] [PATCH v3 2/2] iotests: Test allocate_first_block() with O_DIRECT Nir Soffer
2019-08-27 15:06 ` [Qemu-devel] [PATCH v3 0/2] Optimize alignment probing Nir Soffer
2019-08-27 17:00 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b1dc4ab-f313-2420-7898-66d8ccddae24@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=nirsof@gmail.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).