From: liuzhiwei <zhiwei_liu@c-sky.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Palmer Dabbelt <palmer@sifive.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <Alistair.Francis@wdc.com>
Subject: Re: [Qemu-devel] RISCV: when will the CLIC be ready?
Date: Mon, 19 Aug 2019 21:39:11 +0800 [thread overview]
Message-ID: <2b741fb0-0f12-0f07-a516-9cc23abc0b6e@c-sky.com> (raw)
In-Reply-To: <CAKmqyKPr0V6acB2-Y+N1-aoj-5LSofwi=Jz=u6KFJN1fPUWjzA@mail.gmail.com>
On 2019/8/17 上午1:29, Alistair Francis wrote:
> On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei<zhiwei_liu@c-sky.com> wrote:
>> Hi, Palmer
>>
>> When Michael Clark still was the maintainer of RISCV QEMU, he wrote in the mail list, "the CLIC interrupt controller is under testing,
>> and will be included in QEMU 3.1 or 3.2". It is pity that the CLIC is not in
>> included even in QEMU 4.1.0.
> I see that there is a CLIC branch available here:
> https://github.com/riscv/riscv-qemu/pull/157
>
> It looks like all of the work is in a single commit
> (https://github.com/riscv/riscv-qemu/pull/157/commits/206d9ac339feb9ef2c325402a00f0f45f453d019)
> and that most of the other commits in the PR have already made it into
> master.
>
> Although the CLIC commit is very large it doesn't seem impossible to
> manually pull out the CLIC bits and apply it onto master.
>
> Do you know the state of the CLIC model? If it's working it shouldn't
> be too hard to rebase the work and get the code into mainline.
>
> Alistair
>
Hi, Alistair
In my opinion, the CLIC code almost works.
Last year when my workmate ported an RTOS, I once read the CLIC specification and used the CLIC model code. It worked through all the tests after fixed two bugs. I also had sent the patch to Michael, but without response(maybe a wrong email address).
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 7bf6cbc..95d80ab 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -505,6 +505,9 @@ static target_ulong riscv_intr_pc(CPURISCVState *env,
if (!(async || clic)) {
return tvec & ~0b11;
}
+ if (clic) {
+ cause &= 0x3ff;
+ }
/* bits [1:0] encode mode; 0 = direct, 1 = vectored, 2 >= reserved */
switch (mode1) {
@@ -645,6 +648,9 @@ void riscv_cpu_do_interrupt(CPUState *cs)
riscv_cpu_set_mode(env, PRV_M);
}
+ if (clic) {
+ env->exccode = 0;
+ }
/* NOTE: it is not necessary to yield load reservations here. It is only
necessary for an SC from "another hart" to cause a load reservation
to be yielded. Refer to the memory consistency model section of the
After that, the specification has updated and the code may changed. I didn't pull new code again.
If the CLIC model may merged into the mainline, and no body maintain the code, I'd like to work on it, fixing the bugs and updating the code according to latest specification.
Best Regards,
Zhiwei
>> As we have cpus using CLIC, I have to use the out of tree qemu code in SIFIVE
>> a long time. Could you tell me when it will be upstreamed?
>>
>> Best Regards
>> Zhiwei
>>
next prev parent reply other threads:[~2019-08-19 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 3:34 [Qemu-devel] RISCV: when will the CLIC be ready? liuzhiwei
2019-08-16 17:29 ` Alistair Francis
2019-08-19 13:39 ` liuzhiwei [this message]
2019-08-19 16:38 ` [Qemu-devel] [Qemu-riscv] " Chih-Min Chao
2019-08-21 3:33 ` liuzhiwei
2019-08-22 22:38 ` Alistair Francis
2019-08-19 18:56 ` [Qemu-devel] " Alistair Francis
2019-08-20 1:21 ` Bin Meng
2019-08-21 3:01 ` liuzhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b741fb0-0f12-0f07-a516-9cc23abc0b6e@c-sky.com \
--to=zhiwei_liu@c-sky.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).