From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B3EC433B4 for ; Tue, 6 Apr 2021 22:47:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A2C2613D3 for ; Tue, 6 Apr 2021 22:47:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2C2613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTuTe-0000vI-5H for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 18:47:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTuSa-0000OO-90 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 18:46:12 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:36765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTuSY-0006bd-Dm for qemu-devel@nongnu.org; Tue, 06 Apr 2021 18:46:11 -0400 Received: by mail-pj1-x1031.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so238462pjh.1 for ; Tue, 06 Apr 2021 15:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YcGn4addl8oz00Mb1R7WDdCX+qJS/EZLrrrAYSnDdc4=; b=yLvSvlNEjXWCMJukcJDGErdigpGpqe9xNuA2pZmQUxhY2aYA7+Zd/Hd0XuJ+b7qANo 4OKjIbLlnu3F1v4q0FzUfbDALPc8qO/rgnXTUFS1waLGYjADiSheQfNbZRIbXfebyebu yXQnJ45jz0GiiS7icvBoN5o5LgdXUlx+dYCbrdRon/SBYVb/QZfw0uVadtv9t4hkCCXJ HsTGzqj0YNzMxp1FVuoHA9saImLpZr+A/OuOQee7q41F1HMt1lUd+j3oLBWPkCZXlJm7 Gl3KJq8cLOjq2BmdsdDbbLLMjdmN/QKwg0r9DG8t6vicBMPqEQ3jgcn/wW3TmtoK6gJj yp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YcGn4addl8oz00Mb1R7WDdCX+qJS/EZLrrrAYSnDdc4=; b=ppDnsqsUmHtMEMbbJ2IpMrgO5/gkS9RdLEudNMWqTNFhbVFXg6GFlCI87FQPO1/S3a TEZDAufGCYQVWiwKmwCHsT09Vjd6+PrnFN+xi+vXwCoxsY3AAgTkY+lKH3pMaFWzEO9E zmofAx8470ml1ZzWfgXzUF3CabcTGcppXpbCpmLV9qAzKxncPXpC6jxFQqDTKqHVH11g itEQh0s0Gat8DfcRCXcEf43u7nYoQMbJ8VgYPBiWmxhNvi8OVv/nmF+0xAZY11quEmQy qPyW3uB5pBOh/vbAArfcU9q5GiWp3hU4s6kwiYcRvYLiOCPSDz+HnZtXhU3RgerSwyJ6 0l7w== X-Gm-Message-State: AOAM532j0JZSqXI5EDGqlj1VWZzmnty/jQAq5hqLANQO+37x8AC8tQKz Oyrl/bIC/3BT278tCXFytfPO1g== X-Google-Smtp-Source: ABdhPJyjifCsazRmFdomMwBG0X9faSAKqSojdukWG/uH6xSN7ydZFzw54s0/iK/I9Ouk3Eeba5m24Q== X-Received: by 2002:a17:902:d706:b029:e6:90aa:24e0 with SMTP id w6-20020a170902d706b02900e690aa24e0mr449322ply.42.1617749168488; Tue, 06 Apr 2021 15:46:08 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id k27sm17592161pfg.95.2021.04.06.15.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 15:46:08 -0700 (PDT) Subject: Re: [PATCH v2 19/21] Hexagon (target/hexagon) load and unpack bytes instructions To: Taylor Simpson , qemu-devel@nongnu.org References: <1617249213-22667-1-git-send-email-tsimpson@quicinc.com> <1617249213-22667-20-git-send-email-tsimpson@quicinc.com> From: Richard Henderson Message-ID: <2d07f8de-f52d-0af1-a441-86352cb64004@linaro.org> Date: Tue, 6 Apr 2021 15:46:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1617249213-22667-20-git-send-email-tsimpson@quicinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/31/21 8:53 PM, Taylor Simpson wrote: > Test cases in tests/tcg/hexagon/load_unpack.c > > Signed-off-by: Taylor Simpson > --- > target/hexagon/gen_tcg.h | 108 ++++++++ > target/hexagon/genptr.c | 13 + > target/hexagon/imported/encode_pp.def | 6 + > target/hexagon/imported/ldst.idef | 43 +++ > target/hexagon/macros.h | 16 ++ > tests/tcg/hexagon/Makefile.target | 1 + > tests/tcg/hexagon/load_unpack.c | 474 ++++++++++++++++++++++++++++++++++ > 7 files changed, 661 insertions(+) > create mode 100644 tests/tcg/hexagon/load_unpack.c A couple more inlines, but, Reviewed-by: Richard Henderson r~