From: Kirti Wankhede <kwankhede@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: cohuck@redhat.com, cjia@nvidia.com, aik@ozlabs.ru,
Zhengxiao.zx@Alibaba-inc.com, shuangtai.tst@alibaba-inc.com,
qemu-devel@nongnu.org, peterx@redhat.com, eauger@redhat.com,
yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com,
armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com,
felipe@nutanix.com, zhi.a.wang@intel.com, kevin.tian@intel.com,
yan.y.zhao@intel.com, dgilbert@redhat.com,
changpeng.liu@intel.com, eskultet@redhat.com, Ken.Xue@amd.com,
jonathan.davies@nutanix.com, pbonzini@redhat.com
Subject: Re: [PATCH v26 12/17] vfio: Add function to start and stop dirty pages tracking
Date: Mon, 19 Oct 2020 02:22:21 +0530 [thread overview]
Message-ID: <2d920355-5fc0-9697-727d-678a036581e6@nvidia.com> (raw)
In-Reply-To: <20200925155528.73cdfe09@x1.home>
On 9/26/2020 3:25 AM, Alex Williamson wrote:
> On Wed, 23 Sep 2020 04:54:14 +0530
> Kirti Wankhede <kwankhede@nvidia.com> wrote:
>
>> Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking
>> for VFIO devices.
>>
>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> hw/vfio/migration.c | 36 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
>> index 4306f6316417..822b68b4e015 100644
>> --- a/hw/vfio/migration.c
>> +++ b/hw/vfio/migration.c
>> @@ -11,6 +11,7 @@
>> #include "qemu/main-loop.h"
>> #include "qemu/cutils.h"
>> #include <linux/vfio.h>
>> +#include <sys/ioctl.h>
>>
>> #include "sysemu/runstate.h"
>> #include "hw/vfio/vfio-common.h"
>> @@ -355,6 +356,32 @@ static int vfio_load_device_config_state(QEMUFile *f, void *opaque)
>> return qemu_file_get_error(f);
>> }
>>
>> +static int vfio_set_dirty_page_tracking(VFIODevice *vbasedev, bool start)
>> +{
>> + int ret;
>> + VFIOContainer *container = vbasedev->group->container;
>> + struct vfio_iommu_type1_dirty_bitmap dirty = {
>> + .argsz = sizeof(dirty),
>> + };
>> +
>> + if (start) {
>> + if (vbasedev->device_state & VFIO_DEVICE_STATE_SAVING) {
>> + dirty.flags = VFIO_IOMMU_DIRTY_PAGES_FLAG_START;
>> + } else {
>> + return -EINVAL;
>> + }
>> + } else {
>> + dirty.flags = VFIO_IOMMU_DIRTY_PAGES_FLAG_STOP;
>> + }
>> +
>> + ret = ioctl(container->fd, VFIO_IOMMU_DIRTY_PAGES, &dirty);
>> + if (ret) {
>> + error_report("Failed to set dirty tracking flag 0x%x errno: %d",
>> + dirty.flags, errno);
>> + }
>
> Maybe doesn't matter in the long run, but do you want to use -errno for
> the return rather than -1 from the ioctl on error? Thanks,
>
Makes sense. Changing it.
Thanks,
Kirti
> Alex
>
>> + return ret;
>> +}
>> +
>> /* ---------------------------------------------------------------------- */
>>
>> static int vfio_save_setup(QEMUFile *f, void *opaque)
>> @@ -386,6 +413,11 @@ static int vfio_save_setup(QEMUFile *f, void *opaque)
>> return ret;
>> }
>>
>> + ret = vfio_set_dirty_page_tracking(vbasedev, true);
>> + if (ret) {
>> + return ret;
>> + }
>> +
>> qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
>>
>> ret = qemu_file_get_error(f);
>> @@ -401,6 +433,8 @@ static void vfio_save_cleanup(void *opaque)
>> VFIODevice *vbasedev = opaque;
>> VFIOMigration *migration = vbasedev->migration;
>>
>> + vfio_set_dirty_page_tracking(vbasedev, false);
>> +
>> if (migration->region.mmaps) {
>> vfio_region_unmap(&migration->region);
>> }
>> @@ -734,6 +768,8 @@ static void vfio_migration_state_notifier(Notifier *notifier, void *data)
>> if (ret) {
>> error_report("%s: Failed to set state RUNNING", vbasedev->name);
>> }
>> +
>> + vfio_set_dirty_page_tracking(vbasedev, false);
>> }
>> }
>>
>
next prev parent reply other threads:[~2020-10-18 20:54 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 23:24 [PATCH QEMU v25 00/17] Add migration support for VFIO devices Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 01/17] vfio: Add function to unmap VFIO region Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 02/17] vfio: Add vfio_get_object callback to VFIODeviceOps Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices Kirti Wankhede
2020-09-23 6:38 ` Zenghui Yu
2020-09-24 22:49 ` Alex Williamson
2020-10-21 9:30 ` Zenghui Yu
2020-10-21 19:03 ` Alex Williamson
2020-09-22 23:24 ` [PATCH v26 04/17] vfio: Add migration region initialization and finalize function Kirti Wankhede
2020-09-24 14:08 ` Cornelia Huck
2020-10-17 20:14 ` Kirti Wankhede
2020-09-25 20:20 ` Alex Williamson
2020-09-28 9:39 ` Cornelia Huck
2020-10-17 20:17 ` Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM Kirti Wankhede
2020-09-24 15:02 ` Cornelia Huck
2020-09-29 11:03 ` Dr. David Alan Gilbert
2020-10-17 20:24 ` Kirti Wankhede
2020-10-20 10:51 ` Cornelia Huck
2020-10-21 5:33 ` Kirti Wankhede
2020-10-22 7:51 ` Cornelia Huck
2020-10-22 15:42 ` Kirti Wankhede
2020-10-22 15:49 ` Cornelia Huck
2020-09-25 20:20 ` Alex Williamson
2020-10-17 20:30 ` Kirti Wankhede
2020-10-17 23:44 ` Alex Williamson
2020-10-18 17:43 ` Kirti Wankhede
2020-10-19 17:51 ` Alex Williamson
2020-10-20 10:23 ` Cornelia Huck
2020-09-22 23:24 ` [PATCH v26 06/17] vfio: Add migration state change notifier Kirti Wankhede
2020-09-25 20:20 ` Alex Williamson
2020-10-17 20:35 ` Kirti Wankhede
2020-10-19 17:57 ` Alex Williamson
2020-10-20 10:55 ` Cornelia Huck
2020-09-22 23:24 ` [PATCH v26 07/17] vfio: Register SaveVMHandlers for VFIO device Kirti Wankhede
2020-09-24 15:15 ` Philippe Mathieu-Daudé
2020-09-29 10:19 ` Dr. David Alan Gilbert
2020-10-17 20:36 ` Kirti Wankhede
2020-09-25 11:53 ` Cornelia Huck
2020-10-18 20:55 ` Kirti Wankhede
2020-10-20 15:51 ` Cornelia Huck
2020-09-25 20:20 ` Alex Williamson
2020-10-18 17:40 ` Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers Kirti Wankhede
2020-09-23 11:42 ` Wang, Zhi A
2020-10-21 14:30 ` Kirti Wankhede
2020-09-25 21:02 ` Alex Williamson
2020-10-18 18:00 ` Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 09/17] vfio: Add load " Kirti Wankhede
2020-10-01 10:07 ` Cornelia Huck
2020-10-18 20:47 ` Kirti Wankhede
2020-10-20 16:25 ` Cornelia Huck
2020-09-22 23:24 ` [PATCH v26 10/17] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 11/17] vfio: Get migration capability flags for container Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 12/17] vfio: Add function to start and stop dirty pages tracking Kirti Wankhede
2020-09-25 21:55 ` Alex Williamson
2020-10-18 20:52 ` Kirti Wankhede [this message]
2020-09-22 23:24 ` [PATCH v26 13/17] vfio: create mapped iova list when vIOMMU is enabled Kirti Wankhede
2020-09-25 22:23 ` Alex Williamson
2020-10-19 6:01 ` Kirti Wankhede
2020-10-19 17:24 ` Alex Williamson
2020-10-19 19:15 ` Kirti Wankhede
2020-10-19 20:07 ` Alex Williamson
2020-09-22 23:24 ` [PATCH v26 14/17] vfio: Add vfio_listener_log_sync to mark dirty pages Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 15/17] vfio: Add ioctl to get dirty pages bitmap during dma unmap Kirti Wankhede
2020-09-22 23:24 ` [PATCH v26 16/17] vfio: Make vfio-pci device migration capable Kirti Wankhede
2020-09-25 12:17 ` Cornelia Huck
2020-09-22 23:24 ` [PATCH v26 17/17] qapi: Add VFIO devices migration stats in Migration stats Kirti Wankhede
2020-09-24 15:14 ` Eric Blake
2020-09-25 22:55 ` Alex Williamson
2020-09-29 10:40 ` Dr. David Alan Gilbert
2020-09-23 7:06 ` [PATCH QEMU v25 00/17] Add migration support for VFIO devices Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d920355-5fc0-9697-727d-678a036581e6@nvidia.com \
--to=kwankhede@nvidia.com \
--cc=Ken.Xue@amd.com \
--cc=Zhengxiao.zx@Alibaba-inc.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eauger@redhat.com \
--cc=eskultet@redhat.com \
--cc=felipe@nutanix.com \
--cc=jonathan.davies@nutanix.com \
--cc=kevin.tian@intel.com \
--cc=mlevitsk@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shuangtai.tst@alibaba-inc.com \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
--cc=zhi.a.wang@intel.com \
--cc=ziye.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).