On 27.08.19 20:59, Nir Soffer wrote: > While working on 4k support, I noticed that there is lot of code using > BDRV_SECTOR_SIZE (512) for checking alignment. I wonder how this can work with > 4k storage. > > Lets start by cleaning up to make the code easier to understand: > - Use QEMU_IS_ALIGNED macro to check alignment > - Remove unneeded masks based on BDRV_SECTOR_SIZE > > Nir Soffer (2): > block: Use QEMU_IS_ALIGNED > block: Remove unused masks > > block/bochs.c | 4 ++-- > block/cloop.c | 4 ++-- > block/dmg.c | 4 ++-- > block/io.c | 8 ++++---- > block/qcow2-cluster.c | 4 ++-- > block/qcow2.c | 4 ++-- > block/vvfat.c | 8 ++++---- > include/block/block.h | 2 -- > migration/block.c | 2 +- > qemu-img.c | 2 +- > 10 files changed, 20 insertions(+), 22 deletions(-) Thanks, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block (I think you should check the setting of git config’s user.email in your qemu directory. Even if you send the patches through a gmail address (which I don’t quite know why you’re doing that, but it isn’t like that really matters), the patches should then still contain a “From: ” that shows the actual author as set by user.name and user.email.) Max