qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Huacai Chen <zltjiangshi@gmail.com>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Huacai Chen <chenhuacai@gmail.com>,
	Huacai Chen <chenhc@lemote.com>,
	Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
	qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH V14 2/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)
Date: Fri, 16 Oct 2020 17:12:32 +0200	[thread overview]
Message-ID: <2e4d38f9-b661-6a92-feb4-904a614f4a31@amsat.org> (raw)
In-Reply-To: <1602831120-3377-3-git-send-email-chenhc@lemote.com>

On 10/16/20 8:51 AM, Huacai Chen wrote:
> From: Jiaxun Yang <jiaxun.yang@flygoat.com>
> 
> LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE
> as "load/store quad word" and "shifted load/store" groups of
> instructions.
> 
> This patch add implementation of these instructions:
> gslq: load 16 bytes to GPR
> gssq: store 16 bytes from GPR
> gslqc1: load 16 bytes to FPR
> gssqc1: store 16 bytes from FPR
> 
> Details of Loongson-EXT is here:
> https://github.com/FlyGoat/loongson-insn/blob/master/loongson-ext.md
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>   target/mips/translate.c | 86 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 86 insertions(+)

Build failure:

target/mips/translate.c: In function ‘gen_loongson_lswc2’:
target/mips/translate.c:5928:14: error: unused variable ‘fp0’ 
[-Werror=unused-variable]
  5928 |     TCGv_i32 fp0;
       |              ^~~
target/mips/translate.c:5927:18: error: unused variable ‘t2’ 
[-Werror=unused-variable]
  5927 |     TCGv t0, t1, t2;
       |                  ^~
target/mips/translate.c:5927:14: error: unused variable ‘t1’ 
[-Werror=unused-variable]
  5927 |     TCGv t0, t1, t2;
       |              ^~


  reply	other threads:[~2020-10-16 15:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  6:51 [PATCH V14 0/8] mips: Add Loongson-3 machine support Huacai Chen
2020-10-16  6:51 ` [PATCH V14 1/8] target/mips: Fix PageMask with variable page size Huacai Chen
2020-10-16 15:15   ` Philippe Mathieu-Daudé
2020-10-20  1:38     ` Huacai Chen
2020-10-16  6:51 ` [PATCH V14 2/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1) Huacai Chen
2020-10-16 15:12   ` Philippe Mathieu-Daudé [this message]
2020-10-16  6:51 ` [PATCH V14 3/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 2) Huacai Chen
2020-10-16  6:51 ` [PATCH V14 4/8] target/mips: Add loongson-ext lsdc2 group of instructions Huacai Chen
2020-10-16 14:12   ` Philippe Mathieu-Daudé
2020-10-16  6:51 ` [PATCH V14 5/8] hw/mips: Implement fw_cfg_arch_key_name() Huacai Chen
2020-10-16  6:51 ` [PATCH V14 6/8] hw/mips: Add Loongson-3 boot parameter helpers Huacai Chen
2020-10-16 14:24   ` Philippe Mathieu-Daudé
2020-10-20  2:22     ` Huacai Chen
2020-10-16  6:51 ` [PATCH V14 7/8] hw/mips: Add Loongson-3 machine support Huacai Chen
2020-10-17 15:58   ` Philippe Mathieu-Daudé
2020-10-20  8:05     ` Huacai Chen
2020-10-16  6:52 ` [PATCH V14 8/8] docs/system: Update MIPS machine documentation Huacai Chen
2020-10-16 14:25   ` Philippe Mathieu-Daudé
2020-10-16  7:06 ` [PATCH V14 0/8] mips: Add Loongson-3 machine support no-reply
2020-10-16 16:47 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e4d38f9-b661-6a92-feb4-904a614f4a31@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zltjiangshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).