qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: maozy <maozhongyi@cmss.chinamobile.com>
To: qemu-devel@nongnu.org
Cc: tony.nguyen@bt.com, alex.bennee@linaro.org, armbru@redhat.com,
	laurent@vivier.eu
Subject: Re: [PATCH v2 3/3] tests/migration:fix unreachable path in stress test
Date: Tue, 1 Oct 2019 23:22:13 +0800	[thread overview]
Message-ID: <2e6a6775-f64d-acdd-a345-2bba6edd175d@cmss.chinamobile.com> (raw)
In-Reply-To: <555aac83ecd42d21e6311962e793dd4ce2a77902.1568170994.git.maozhongyi@cmss.chinamobile.com>


ping...


On 9/11/19 11:31 AM, Mao Zhongyi wrote:
> if stress function always return 0, the path
> 'if (stress(ramsizeGB, ncpus) < 0)' is nerver unreachable,
> so fix it to allow the test failed.
>
> Cc: armbru@redhat.com
> Cc: laurent@vivier.eu
> Cc: tony.nguyen@bt.com
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
>   tests/migration/stress.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/migration/stress.c b/tests/migration/stress.c
> index 19a6eff5fd..35903d90c4 100644
> --- a/tests/migration/stress.c
> +++ b/tests/migration/stress.c
> @@ -224,6 +224,7 @@ static int stressone(unsigned long long ramsizeMB)
>               }
>           }
>       }
> +    return 0;
>   }
>   
>   
> @@ -248,9 +249,7 @@ static int stress(unsigned long long ramsizeGB, int ncpus)
>                          stressthread,   &ramsizeMB);
>       }
>   
> -    stressone(ramsizeMB);
> -
> -    return 0;
> +    return stressone(ramsizeMB);
>   }
>   
>   




  reply	other threads:[~2019-10-01 15:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  3:31 [Qemu-devel] [PATCH v2 0/3] some fix in tests/migration Mao Zhongyi
2019-09-11  3:31 ` [Qemu-devel] [PATCH v2 1/3] tests/migration: mem leak fix Mao Zhongyi
2019-09-11  8:21   ` Alex Bennée
2019-10-01 15:31   ` Laurent Vivier
2019-10-03  5:34     ` maozy
2019-09-11  3:31 ` [Qemu-devel] [PATCH v2 2/3] tests/migration: fix a typo in comment Mao Zhongyi
2019-10-01 15:31   ` Laurent Vivier
2019-10-04 14:23   ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-09-11  3:31 ` [Qemu-devel] [PATCH v2 3/3] tests/migration:fix unreachable path in stress test Mao Zhongyi
2019-10-01 15:22   ` maozy [this message]
2019-10-01 15:46   ` Laurent Vivier
2019-10-03  7:17     ` _[PATCH_v2_3/3]_tests/migration:fix_unreachable_path_in_stress_test maozy
2019-10-03  9:23       ` _[PATCH_v2_3/3]_tests/migration:fix_unreachable_path_in_stress_test Laurent Vivier
2019-10-04  1:59         ` _[PATCH_v2_3/3]_tests/migration:fix_unreachable_path_in_stress_test maozy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e6a6775-f64d-acdd-a345-2bba6edd175d@cmss.chinamobile.com \
    --to=maozhongyi@cmss.chinamobile.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=tony.nguyen@bt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).