From: Paolo Bonzini <pbonzini@redhat.com>
To: minyard@acm.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <famz@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 00/15] ipmi: Bug fixes, add new interfaces
Date: Fri, 20 Sep 2019 13:43:32 +0200 [thread overview]
Message-ID: <2e9b4b2e-ac56-6039-a800-fbdc48ca1958@redhat.com> (raw)
In-Reply-To: <20190919213924.31852-1-minyard@acm.org>
On 19/09/19 23:39, minyard@acm.org wrote:
> I haven't gotten a lot of commentary on this, but I assume that means
> that everything is ok. It's been posted a few times and the last time
> I received no issues, just a couple of reviews. I would like more
> review. But I'm not quite sure what to do about that, I've been
> hanging on to these changes far too long.
It's just that not many people here are IPMI-savvy. I took a quick look
at patches 5 and 15, and they look fine.
Paolo
> The following changes since commit a77d20bafcd4cb7684168a9b4c6dc2a321aaeb50:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190919-pull-request' into staging (2019-09-19 17:16:07 +0100)
>
> are available in the Git repository at:
>
> https://github.com/cminyard/qemu.git tags/ipmi-for-release-2019-09-19
>
> for you to fetch changes up to d9b74295c6528fd68cebdea116b283e46543b2a2:
>
> pc: Add an SMB0 ACPI device to q35 (2019-09-19 14:41:58 -0500)
>
> ----------------------------------------------------------------
> ipmi: Some bug fixes and new interfaces
>
> Some bug fixes for the watchdog and hopeful the BT tests.
>
> Change the IPMI UUID handling to give the user the ability to set it or
> not have it.
>
> Add a PCI interface.
>
> Add an SMBus interfaces.
>
> -corey
>
> ----------------------------------------------------------------
> Corey Minyard (15):
> ipmi: Fix watchdog NMI handling
> ipmi: Fix the get watchdog command
> ipmi: Generate an interrupt on watchdog pretimeout expiry
> tests:ipmi: Fix IPMI BT tests
> qdev: Add a no default uuid property
> ipmi: Add a UUID device property
> ipmi: Split out KCS-specific code from ISA KCS code
> ipmi: Split out BT-specific code from ISA BT code
> ipmi: Allow a size value to be passed for I/O space
> smbios:ipmi: Ignore IPMI devices with no fwinfo function
> ipmi: Add PCI IPMI interfaces
> ipmi: Add an SMBus IPMI interface
> acpi: Add i2c serial bus CRS handling
> ipmi: Fix SSIF ACPI handling to use the right CRS
> pc: Add an SMB0 ACPI device to q35
>
> default-configs/i386-softmmu.mak | 3 +
> hw/acpi/aml-build.c | 40 ++++
> hw/acpi/ipmi-stub.c | 2 +-
> hw/acpi/ipmi.c | 13 +-
> hw/i386/Kconfig | 3 +
> hw/i386/acpi-build.c | 17 +-
> hw/i386/pc_piix.c | 12 +-
> hw/i386/pc_q35.c | 9 +-
> hw/ipmi/Kconfig | 15 ++
> hw/ipmi/Makefile.objs | 5 +-
> hw/ipmi/ipmi.c | 6 +-
> hw/ipmi/ipmi_bmc_sim.c | 30 ++-
> hw/ipmi/ipmi_bt.c | 437 ++++++++++++++++++++++++++++++++++++++
> hw/ipmi/ipmi_kcs.c | 423 +++++++++++++++++++++++++++++++++++++
> hw/ipmi/isa_ipmi_bt.c | 443 ++-------------------------------------
> hw/ipmi/isa_ipmi_kcs.c | 419 ++----------------------------------
> hw/ipmi/pci_ipmi_bt.c | 146 +++++++++++++
> hw/ipmi/pci_ipmi_kcs.c | 146 +++++++++++++
> hw/ipmi/smbus_ipmi.c | 384 +++++++++++++++++++++++++++++++++
> hw/smbios/smbios_type_38.c | 3 +
> include/hw/acpi/aml-build.h | 18 ++
> include/hw/acpi/ipmi.h | 2 +-
> include/hw/i386/pc.h | 2 +
> include/hw/ipmi/ipmi.h | 7 +-
> include/hw/ipmi/ipmi_bt.h | 73 +++++++
> include/hw/ipmi/ipmi_kcs.h | 76 +++++++
> include/hw/pci/pci.h | 1 +
> include/hw/qdev-properties.h | 7 +
> qemu-options.hx | 10 +-
> tests/Makefile.include | 3 +-
> tests/data/acpi/q35/DSDT | Bin 7841 -> 7879 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 7858 -> 7896 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8304 -> 8342 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9494 -> 9532 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 7916 -> 7954 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9200 -> 9238 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 8971 -> 9009 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 7847 -> 7885 bytes
> tests/ipmi-bt-test.c | 6 +-
> 39 files changed, 1902 insertions(+), 859 deletions(-)
> create mode 100644 hw/ipmi/ipmi_bt.c
> create mode 100644 hw/ipmi/ipmi_kcs.c
> create mode 100644 hw/ipmi/pci_ipmi_bt.c
> create mode 100644 hw/ipmi/pci_ipmi_kcs.c
> create mode 100644 hw/ipmi/smbus_ipmi.c
> create mode 100644 include/hw/ipmi/ipmi_bt.h
> create mode 100644 include/hw/ipmi/ipmi_kcs.h
>
>
>
next prev parent reply other threads:[~2019-09-20 11:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 21:39 [PATCH 00/15] ipmi: Bug fixes, add new interfaces minyard
2019-09-19 21:39 ` [PATCH 01/15] ipmi: Fix watchdog NMI handling minyard
2019-09-20 15:45 ` Cédric Le Goater
2019-09-19 21:39 ` [PATCH 02/15] ipmi: Fix the get watchdog command minyard
2019-09-20 15:50 ` Cédric Le Goater
2019-09-19 21:39 ` [PATCH 03/15] ipmi: Generate an interrupt on watchdog pretimeout expiry minyard
2019-09-23 5:41 ` Cédric Le Goater
2019-09-19 21:39 ` [PATCH 04/15] tests:ipmi: Fix IPMI BT tests minyard
2019-09-19 21:39 ` [PATCH 05/15] qdev: Add a no default uuid property minyard
2019-09-23 5:47 ` Cédric Le Goater
2019-09-19 21:39 ` [PATCH 06/15] ipmi: Add a UUID device property minyard
2019-09-23 5:51 ` Cédric Le Goater
2019-09-19 21:39 ` [PATCH 07/15] ipmi: Split out KCS-specific code from ISA KCS code minyard
2019-09-19 21:39 ` [PATCH 08/15] ipmi: Split out BT-specific code from ISA BT code minyard
2019-09-19 21:39 ` [PATCH 09/15] ipmi: Allow a size value to be passed for I/O space minyard
2019-09-19 21:39 ` [PATCH 10/15] smbios:ipmi: Ignore IPMI devices with no fwinfo function minyard
2019-09-19 21:39 ` [PATCH 11/15] ipmi: Add PCI IPMI interfaces minyard
2019-09-19 21:39 ` [PATCH 12/15] ipmi: Add an SMBus IPMI interface minyard
2022-06-28 16:21 ` Peter Maydell
2022-07-29 15:34 ` Peter Maydell
2022-07-29 15:56 ` Corey Minyard
2022-07-29 16:01 ` Peter Maydell
2019-09-19 21:39 ` [PATCH 13/15] acpi: Add i2c serial bus CRS handling minyard
2019-09-19 21:39 ` [PATCH 14/15] ipmi: Fix SSIF ACPI handling to use the right CRS minyard
2019-09-19 21:39 ` [PATCH 15/15] pc: Add an SMB0 ACPI device to q35 minyard
2019-09-20 11:43 ` Paolo Bonzini [this message]
2019-09-20 12:19 ` [PATCH 00/15] ipmi: Bug fixes, add new interfaces Corey Minyard
2019-09-20 12:57 ` Peter Maydell
2019-09-20 17:36 ` Corey Minyard
2019-09-20 17:51 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9b4b2e-ac56-6039-a800-fbdc48ca1958@redhat.com \
--to=pbonzini@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=famz@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).