From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] readconfig-test: add test for accelerator configuration
Date: Tue, 31 Jan 2023 16:18:54 +0100 [thread overview]
Message-ID: <2f17c06f-90a9-9bac-8e9a-a1a2842665d2@redhat.com> (raw)
In-Reply-To: <20230117080745.43247-5-pbonzini@redhat.com>
On 17/01/2023 09.07, Paolo Bonzini wrote:
> Test that invalid configurations do not cause a SIGSEGV, and cover a
> valid configuration as well.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/libqtest.c | 28 +++++++++++++++++-----
> tests/qtest/libqtest.h | 12 ++++++++++
> tests/qtest/readconfig-test.c | 45 ++++++++++++++++++++++++++++-------
> 3 files changed, 70 insertions(+), 15 deletions(-)
>
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index 64ba98bc5853..53d766fe3fa5 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -402,6 +402,26 @@ static QTestState *G_GNUC_PRINTF(1, 0) qtest_spawn_qemu(const char *fmt, ...)
> return s;
> }
>
> +QTestState *G_GNUC_PRINTF(1, 0) qtest_init_bare(const char *args)
I think you don't need the G_GNUC_PRINTF here, do you?
Thomas
next prev parent reply other threads:[~2023-01-31 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 8:07 [PATCH 0/4] vl: avoid SIGSEGV on invalid [accel] configuration Paolo Bonzini
2023-01-17 8:07 ` [PATCH 1/4] vl: catch [accel] entry without accelerator Paolo Bonzini
2023-01-17 8:10 ` Philippe Mathieu-Daudé
2023-01-17 8:07 ` [PATCH 2/4] libqtest: split qtest_spawn_qemu function Paolo Bonzini
2023-01-17 8:14 ` Philippe Mathieu-Daudé
2023-01-31 15:12 ` Thomas Huth
2023-01-17 8:07 ` [PATCH 3/4] libqtest: ensure waitpid() is only called once Paolo Bonzini
2023-01-31 15:14 ` Thomas Huth
2023-01-17 8:07 ` [PATCH 4/4] readconfig-test: add test for accelerator configuration Paolo Bonzini
2023-01-31 15:18 ` Thomas Huth [this message]
2023-01-31 15:20 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f17c06f-90a9-9bac-8e9a-a1a2842665d2@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).