From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39247C433E0 for ; Wed, 3 Jun 2020 05:05:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBBF620679 for ; Wed, 3 Jun 2020 05:05:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IZY5IbgN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBBF620679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgLad-0003TZ-3g for qemu-devel@archiver.kernel.org; Wed, 03 Jun 2020 01:05:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgLZu-0002xc-1h for qemu-devel@nongnu.org; Wed, 03 Jun 2020 01:04:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55098 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jgLZs-0006yy-JO for qemu-devel@nongnu.org; Wed, 03 Jun 2020 01:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591160675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fsc7l/HLVwthw3zdCUfo6CryjCG4GjtzYedjBKe7z5E=; b=IZY5IbgNOVEiyuPCq2raWZUWeOORYoeIHXhWxaQN0u4m8q7ks4urBs/Lqo/iEBecUuD3DN IggFH2TPc6uG/JbK3Ma1w33hHUB1+LF51F+ugSwzkSRZBQd6Ip9vFffxrGYdQnHCpFdZYh i/nPZ1Dkh+ylt/2YqcOcrRSG2oEKYBc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-e8ZrvThcN5-WoDFRTHEd9A-1; Wed, 03 Jun 2020 01:04:30 -0400 X-MC-Unique: e8ZrvThcN5-WoDFRTHEd9A-1 Received: by mail-wm1-f69.google.com with SMTP id x6so408356wmj.9 for ; Tue, 02 Jun 2020 22:04:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Fsc7l/HLVwthw3zdCUfo6CryjCG4GjtzYedjBKe7z5E=; b=pevMOggltRxNQKIWF8WWr+H+FhV/pHTOfJgMTBuOk7MmPcpR0HXXCc96AVvvx/cvw6 L83ZNR96hhbc6qbYEnet80AprJJEf22WxHla6B0KeWM5sZe3MbL31v9bIMo/JwAwF9xM CAFFrUGKCOGGVG0xiEuv4Rb3K0uheQz4M2b+6gHInUEPvT/ZZq8UfYS4aBE830+zXH2y JASUKLes7E3ZQgr2cB4iyB8z5w7OVdX3ZUQUW6GCTLY4EwbKKnk2HLGg5NE+kdY9O9qz ayy1fbIkiFl5gxmbGPMPfu7JIZywoXNHnd4gIrGeZSg7zumgLCcW93aPKSBNq2eIA4fO kTfA== X-Gm-Message-State: AOAM5324XIgA4tR7qTM00nYsQTNdcIidoManFmAjellQqgky2DkHsOSF uco8lXjJOxIyr4kHkbNyqKnJ2LvFjLtHF3Z7BX+gYcUdEllSEijFvcx5QBUvGE6Jbkjg4hvqcQ9 JGS/ndvYas6mrDZA= X-Received: by 2002:a05:6000:1104:: with SMTP id z4mr28744764wrw.272.1591160669079; Tue, 02 Jun 2020 22:04:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAUwR/BO07GjJYalKT7BNcDwKcWw4gKo0UFwe2mJcyXiwdkUNQbHl50NmsrN7tmiOfWxTJlg== X-Received: by 2002:a05:6000:1104:: with SMTP id z4mr28744747wrw.272.1591160668875; Tue, 02 Jun 2020 22:04:28 -0700 (PDT) Received: from [192.168.1.43] (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id p16sm1649665wru.27.2020.06.02.22.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 22:04:28 -0700 (PDT) Subject: Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef To: qemu-devel@nongnu.org References: <20200505142836.16903-1-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <303faba8-851f-a0da-4df3-0d57ffd1ff14@redhat.com> Date: Wed, 3 Jun 2020 07:04:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200505142836.16903-1-philmd@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 01:04:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Richard Henderson , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote: > Drop superfluous parenthesis around VMPortReadFunc typedef > (added in d67f679d99, missed to remove when moved in e595112985). > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/vmport.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h > index 47eda7a22b..a6624e3045 100644 > --- a/hw/i386/vmport.h > +++ b/hw/i386/vmport.h > @@ -27,7 +27,7 @@ > > #define TYPE_VMPORT "vmport" > > -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address); > +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address); > > void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque); > > ping?