From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497E4C4360C for ; Tue, 8 Oct 2019 14:28:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13781205C9 for ; Tue, 8 Oct 2019 14:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="tF4Mv6r/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13781205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHqTg-0007qH-W3 for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 10:28:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49822) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHqR5-00061j-Ob for qemu-devel@nongnu.org; Tue, 08 Oct 2019 10:26:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHqR4-0008I0-Bn for qemu-devel@nongnu.org; Tue, 08 Oct 2019 10:25:59 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:55729) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHqR2-0008Cj-VY for qemu-devel@nongnu.org; Tue, 08 Oct 2019 10:25:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=JjfHH10wMmWdQzIpyfW+Y+c5Zivig6jKcZR6vgyGqiM=; b=tF4Mv6r/Pgix7ExNHICCFqEp7G 00JbrbQnkBhZXLdbHs2J6S6jAz3nH1ZZ/IB/74+dq1pscLJjDom4VBDZKYuY/Pv0yGihf9TSkJ5gJ +JdsUxXhfnehf7f7hzPB5G04TKV310IRywmuT+vV5hj7JSzFGiBn28xvzDUh8yb7CsmIAXXvd+0Vv TE6mkWZfy7BTuCR9VRpqQTSPAB1Nn9gsbYTmt/TzkPf/PfDUqtA0Fgj1+a2k0469QC+4Hakea4Ydg eGSnD2iVKZagMVeO+G5tQ9BVlCJfOB+/OgLYtzgONo//qiaxiyIUu/+EogBJrNFCTzxDeRIIhPHFx YRoP2EQEKv5ZeEmnSiHi3GkE0f3xfA0xK/0kOnGfGLyGBweXR80BL/EDOI3hJPUpclang8UljF3BE euPVo4e2VHpduPJAziRf/P+3s/urMQvu8lx2UnJyUq2cpxjIu1uFccZoQTR41h+kbz7J2hBUz2BGf f9ng5dJ1MG2Rq/br3oQk5GW14+u/6dNhZ7SDoraDN8mWjUONBkXyLLfJj9h7Bb7r6lo/vkfPQU/a1 D62F/se9n4cd+GeztbUHER7J8ZUbK1Jz0I2jT7JmglR8Bizx1R9mHbwT3XpjOBIYDJgkfkK50HQ+4 tsW5infJEVNc0XJyPopVsyW7d9iMzRnkSD1MUUOnQ=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Greg Kurz , Christian Schoenebeck , Stefan Hajnoczi , Daniel =?ISO-8859-1?Q?P=2E_Berrang=E9?= , Antonios Motakis , "Dr. David Alan Gilbert" Subject: Re: [Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions Date: Tue, 08 Oct 2019 16:25:48 +0200 Message-ID: <30797240.IXYi3n4lAo@silver> In-Reply-To: <20191008154729.5b16ef26@bahia.lan> References: <2456208.kOTvEbKLdM@silver> <20191008154729.5b16ef26@bahia.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.189.157.229 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Dienstag, 8. Oktober 2019 15:47:29 CEST Greg Kurz wrote: > On Tue, 08 Oct 2019 14:05:28 +0200 > > Christian Schoenebeck wrote: > > On Dienstag, 8. Oktober 2019 11:14:59 CEST Greg Kurz wrote: > > > > No, it is not a feature. It is still a fix. :) I cannot use 9p without > > > > this > > > > fix at all, so it is not some optional "feature" for me. > > > > > > I understand your need but this is still arguable. The 9p device has > > > a limitation with cross-device setups. The actual bug is to silently > > > cause inode number collisions in the guest. This is partly fixed by the > > > "9p: Treat multiple devices on one export as an error" patch. Thinking > > > again, it would even make sense to move "remap" from "9p: Added virtfs > > > option 'multidevs=remap|forbid|warn'" to its own patch. We could then > > > consider that the bug is fully fixed with "multidevs=forbid|warn". > > > > > > Then comes the "remap" feature which is expected to lift the limitation > > > with cross-device setups, with a "not yet determined" performance cost > > > and light reviewing of the code. > > > > Are these patch transfer requests addressed at me to be done? > > It would certainly be appreciated :) and if it happens to be done > before 2019-10-29, it can even be shipped with QEMU 4.2. Just to avoid any misapprehension, since today's comments of yours made me sceptical: that would be a) PR for QEMU 4.2 for *all* QID patches up to and including remapping with variable suffix (e.g. as -multidevs=x-remap)? or is your current plan rather b) to ship the discussed 9p patches for QEMU 4.2 only up to a certain patch like multidevs=warn|forbid and all subsequent patches "might" then be merged to master somewhere in distant future? Best regards, Christian Schoenebeck