QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, lichun <lichun@ruijie.com.cn>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, 706701795@qq.com
Subject: Re: [PATCH v2] chardev/tcp: fix error message double free error
Date: Wed, 1 Jul 2020 15:09:08 +0200
Message-ID: <309b915a-9ddc-95a7-f579-7cf66a7c0253@redhat.com> (raw)
In-Reply-To: <87zh8jbtpd.fsf@dusky.pond.sub.org>

On 01/07/20 09:06, Markus Armbruster wrote:
> lichun <lichun@ruijie.com.cn> writes:
> 
>> Signed-off-by: lichun <lichun@ruijie.com.cn>
>> ---
>>  chardev/char-socket.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
>> index afebeec5c3..569d54c144 100644
>> --- a/chardev/char-socket.c
>> +++ b/chardev/char-socket.c
>> @@ -142,6 +142,8 @@ static void check_report_connect_error(Chardev *chr,
>>                            "Unable to connect character device %s: ",
>>                            chr->label);
>>          s->connect_err_reported = true;
>> +    } else {
>> +        error_free(err);
>>      }
>>      qemu_chr_socket_restart_timer(chr);
>>  }
>> @@ -1086,7 +1088,6 @@ static void qemu_chr_socket_connected(QIOTask *task, void *opaque)
>>      if (qio_task_propagate_error(task, &err)) {
>>          tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);
>>          check_report_connect_error(chr, err);
>> -        error_free(err);
>>          goto cleanup;
>>      }
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 
> and queued, thanks!
> 

Can you please add a note to the commit message?

    Errors are already freed by error_report_err, so we only need to call
    error_free when that function is not called.
    
and Cc qemu-stable?  Or I can queue it too since it's chardev stuff.



  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 21:30 lichun
2020-06-25  6:47 ` Markus Armbruster
2020-06-25  9:25   ` Marc-André Lureau
2020-06-28  2:19     ` lichun
2020-07-01  7:06 ` Markus Armbruster
2020-07-01 13:09   ` Paolo Bonzini [this message]
2020-07-01 15:12     ` lichun
2020-07-01 15:14       ` Paolo Bonzini
2020-07-02  4:25     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309b915a-9ddc-95a7-f579-7cf66a7c0253@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=706701795@qq.com \
    --cc=armbru@redhat.com \
    --cc=lichun@ruijie.com.cn \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git