From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AFAC433E7 for ; Mon, 19 Oct 2020 23:23:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83595208B8 for ; Mon, 19 Oct 2020 23:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nhvb3Sff" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83595208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUeVR-0002Oc-Fz for qemu-devel@archiver.kernel.org; Mon, 19 Oct 2020 19:23:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUeR9-0007Kj-H2 for qemu-devel@nongnu.org; Mon, 19 Oct 2020 19:19:33 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:35068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUeR5-0008UL-5A for qemu-devel@nongnu.org; Mon, 19 Oct 2020 19:19:30 -0400 Received: by mail-pj1-x1043.google.com with SMTP id h4so69319pjk.0 for ; Mon, 19 Oct 2020 16:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XZbyhQGZdaoUeQwkWb6o6aGxcF2rkEztvcTQoIWH4uE=; b=Nhvb3SffknGY7sijupVvF7owMWwThL0FL8GQfhjhOUAtHaITlG2YoGhgiIPjBxX5vG sL1/N1iP/Zc1fZZN7xKj3n/JrBb25vekzdTd0MjrnS8GUU6GCRQUxVnal6pkydhiE5jq kh0myQ/B1hI2NBo782A3OLTZ6bpQb/R3SnnvrJLsUEjUMOM4e6da9ZuTBjyECGM6JPIs KAxgEI7rbKoFVDRGv9/FO8XlOaaLM/UThSf13JDXO5XMKuozorR7RScmYY7xkTXHcRG7 PT9N+Z92KisWdBWizuqeL7ys+yRg3Z56tdpupALEMdD/97BYuP1zvFjsZ3BkJmlh79RV V5pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XZbyhQGZdaoUeQwkWb6o6aGxcF2rkEztvcTQoIWH4uE=; b=r6vMaQDvz8mSh4pCPrYyGSSDbzUfpDcR8tpNjPsgDD0nUyXIaoYUCg95KA0UKzJtlz PoNztCBcJrdHTPQb+7AkNDkOJhbt4uPujVTbIT3L4R9gX8nl/TpGv0vGLiuhr16Lxhal HH9AFfQCyjXDGwJgSPZQwHaJvQl5TCzQtJqKF5IbIad1xU/f1cPr/yLeyF/JgZCgw0zt NYL4ugajG9D3LKZAQhkj2D37Jr8GQ8i15XW+kVQALokGFacXD5/smkCHhCvCoMFXZscT oCpeVZ+soDwLxIvpxZLGTf/fxCNa4v6BGsY1CTbcXbIJxQgqSV5+fArvK98SzaIWAtir sGxA== X-Gm-Message-State: AOAM533I45XuATPMLNQyCyVoyDLa9bR4MLcAiCNGqXvIaQXRgO3bCVi9 i6ujGP0+MPP7RB9C3QQmkJh3Rg== X-Google-Smtp-Source: ABdhPJzzU1gKQmw/fXSYgHC4NRb1jMpaedfQKz+sLAzd3gkVl+hlPFrnn8K74COHkzJOlO3fcneTcw== X-Received: by 2002:a17:90b:3649:: with SMTP id nh9mr109203pjb.123.1603149565605; Mon, 19 Oct 2020 16:19:25 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id g22sm52588pfh.147.2020.10.19.16.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 16:19:24 -0700 (PDT) Subject: Re: [PATCH v2 5/9] tcg: add const hints for code pointers To: Joelle van Dyne , qemu-devel@nongnu.org References: <20201019013928.72770-1-j@getutm.app> <20201019013928.72770-6-j@getutm.app> From: Richard Henderson Message-ID: <30c59d7a-a11f-5d9b-4dcc-eb8cf120a4cb@linaro.org> Date: Mon, 19 Oct 2020 16:19:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201019013928.72770-6-j@getutm.app> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1043; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1043.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , "open list:RISC-V TCG target" , Stefan Weil , Aleksandar Markovic , "open list:S390 TCG target" , "open list:AArch64 TCG target" , Palmer Dabbelt , Huacai Chen , Alistair Francis , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > We will introduce mirror mapping for JIT segment with separate RX and RW > access. Adding 'const' hints will make it easier to identify read-only > accesses and allow us to easier catch bugs at compile time in the future. > > Signed-off-by: Joelle van Dyne Are you "osy"? We do need S-o-b with real names from all contributors to the patch. The patch is bigger than I would like, but it all appears to be strongly connected, and I don't see where it could be split. I'm inclined to cherry-pick this patch out now to avoid carrying it around. So if I can either fix the --author to you, or we can get a s-o-b from the author, I'll do that. r~