From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94967C433ED for ; Wed, 7 Apr 2021 15:12:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09A7A61222 for ; Wed, 7 Apr 2021 15:12:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09A7A61222 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU9r1-0000B9-U1 for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 11:12:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU9q6-00081r-20 for qemu-devel@nongnu.org; Wed, 07 Apr 2021 11:11:30 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:36184 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU9q3-0003Hm-GR for qemu-devel@nongnu.org; Wed, 07 Apr 2021 11:11:29 -0400 Received: from host86-148-103-9.range86-148.btcentralplus.com ([86.148.103.9] helo=[192.168.1.65]) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lU9qB-0004Xp-L4; Wed, 07 Apr 2021 16:11:36 +0100 To: Alexander Bulekov References: <20210402162052.264952-1-alxndr@bu.edu> <0c024eae-533b-f3fa-8878-9f90d283eef9@ilande.co.uk> <20210407144930.3332oqbwzidrou6z@mozz.bu.edu> From: Mark Cave-Ayland Message-ID: <30d2b8d8-2861-509b-16be-34767b4cbe4d@ilande.co.uk> Date: Wed, 7 Apr 2021 16:11:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210407144930.3332oqbwzidrou6z@mozz.bu.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 86.148.103.9 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH] tests/qtest: add one more test for the am53c974 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Thomas Huth , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 07/04/2021 15:49, Alexander Bulekov wrote: > Hi Mark, > I guess there must have been something timing-sensitive in the > reproducer... Too bad it didn't work. Yeah, it would have been nice to have something that could be triggered directly by a test but never mind. >> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c >> index 0037197bdb..b668acef82 100644 >> --- a/hw/scsi/esp.c >> +++ b/hw/scsi/esp.c >> @@ -357,6 +357,7 @@ static void handle_satn(ESPState *s) >> cmdlen = get_cmd(s, ESP_CMDFIFO_SZ); >> if (cmdlen > 0) { >> s->cmdfifo_cdb_offset = 1; >> + s->do_cmd = 0; >> do_cmd(s); >> } else if (cmdlen == 0) { >> s->do_cmd = 1; >> @@ -390,6 +391,7 @@ static void handle_s_without_atn(ESPState *s) >> cmdlen = get_cmd(s, ESP_CMDFIFO_SZ); >> if (cmdlen > 0) { >> s->cmdfifo_cdb_offset = 0; >> + s->do_cmd = 0; >> do_busid_cmd(s, 0); >> } else if (cmdlen == 0) { >> s->do_cmd = 1; >> > > With this applied, I don't see either of those asserts anymore. > Thank you! > -Alex Awesome! I'll include this in v4. BTW does this now mean that the am53c974 survives a run through your fuzzer corpus? ATB, Mark.