From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [RFC PATCH v2 03/11] qemu-iotests: add option to attach gdbserver
Date: Thu, 8 Apr 2021 18:02:04 +0200 [thread overview]
Message-ID: <30e729cd-fb0c-f6d9-a545-fd9bd0e419a0@redhat.com> (raw)
In-Reply-To: <cb21196a-b66c-93c5-90e8-0dcf2fa0b453@redhat.com>
On 08/04/2021 17:40, Paolo Bonzini wrote:
> On 07/04/21 15:50, Emanuele Giuseppe Esposito wrote:
>> + self.gdb_qemu = os.getenv('GDB_QEMU')
>> +
>> + if gdb and not self.gdb_qemu:
>> + self.gdb_qemu = 'localhost:12345'
>> + elif self.gdb_qemu and not gdb:
>> + del self.gdb_qemu
>> + del os.environ['GDB_QEMU']
>
> Alternatively:
>
> if gdb:
> self.gdb_qemu = os.environ.get('GDB_QEMU', 'localhost:12345')
> elif 'GDB_QEMU' in os.environ:
> del os.environ['GDB_QEMU']
makes sense, thanks.
>
>> +GDB_QEMU -- "{GDB_QEMU}"
>
> Perhaps only include this if gdbserver is actually in use? (Or not at
> all, since gdbserver anyway prints the port).
You forgot that by default all logs go to a log file :) so unless you
find the corresponding log, it is not easy to find the GDB port.
Thank you,
Emanuele
>
> Paolo
>
next prev parent reply other threads:[~2021-04-08 16:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 13:50 [RFC PATCH v2 00/11] qemu_iotests: improve debugging options Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 01/11] python: qemu: add timer parameter for qmp.accept socket Emanuele Giuseppe Esposito
2021-04-08 19:51 ` John Snow
2021-04-09 16:01 ` Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 02/11] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine Emanuele Giuseppe Esposito
2021-04-08 19:59 ` John Snow
2021-04-09 16:07 ` Emanuele Giuseppe Esposito
2021-04-09 16:37 ` John Snow
2021-04-07 13:50 ` [RFC PATCH v2 03/11] qemu-iotests: add option to attach gdbserver Emanuele Giuseppe Esposito
2021-04-08 15:40 ` Paolo Bonzini
2021-04-08 16:02 ` Emanuele Giuseppe Esposito [this message]
2021-04-07 13:50 ` [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers Emanuele Giuseppe Esposito
2021-04-08 15:40 ` Paolo Bonzini
2021-04-08 16:06 ` Emanuele Giuseppe Esposito
2021-04-08 19:03 ` Paolo Bonzini
2021-04-09 16:13 ` Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 05/11] qemu_iotests: insert gdbserver command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 06/11] qemu-iotests: add gdbserver option to script tests too Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 07/11] qemu_iotests: extend the check script to support valgrind for python tests Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 08/11] qemu_iotests: extent QMP socket timeout when using valgrind Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 09/11] qemu_iotests: allow valgrint to print/delete the generated log file Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 10/11] qemu_iotests: insert valgrind command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 11/11] qemu_iotests: add option to show qemu binary logs on stdout Emanuele Giuseppe Esposito
2021-04-08 8:26 ` [RFC PATCH v2 00/11] qemu_iotests: improve debugging options Markus Armbruster
2021-04-08 11:15 ` Emanuele Giuseppe Esposito
2021-04-08 12:39 ` Markus Armbruster
2021-04-08 13:41 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e729cd-fb0c-f6d9-a545-fd9bd0e419a0@redhat.com \
--to=eesposit@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).