From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93481C433ED for ; Mon, 19 Apr 2021 17:41:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7E91611F2 for ; Mon, 19 Apr 2021 17:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7E91611F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYXth-0000f5-2w for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 13:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYXrv-0008JA-5t for qemu-devel@nongnu.org; Mon, 19 Apr 2021 13:39:31 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:33343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYXrt-0006Gh-LF for qemu-devel@nongnu.org; Mon, 19 Apr 2021 13:39:30 -0400 Received: by mail-pg1-x52a.google.com with SMTP id t22so24796649pgu.0 for ; Mon, 19 Apr 2021 10:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YLvn9Nt2e6/wyC0+bTf0onzCVTduNJel2budRDmQOyc=; b=p9gpDJioTiPzAEma0fNWdzEHuVPh7T4z6sy5+p0CRChnVVX6qM8Pe1/rpBFkVpBFji Tp3ZWO+jGbdEH5vid+k4CqfIAEk0urZPlAUC3Tio7bxgWKmtnpIBp+XNQVfthBsBJqnI mzWbIZEM+SbdEKGsVsU6ylBywcCno5rMpG4DhTyWv5zL7s9S+MlhGbz493QisHVWc3eh d9v51G2dd0xeRraW2ByIzLNn53l8zVMAl0uqCYCrbTsip+tK/JfaAscUr9vbEfKH3uVs gfcj6FU/NNNIrkv1fVyeJbxLRgBpOH15fLbwkppmh+y4t8TkoDC0zidlSEodYNVAcl12 IRPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YLvn9Nt2e6/wyC0+bTf0onzCVTduNJel2budRDmQOyc=; b=mcwDZjDXVfBdusUigIodnW3EnaxE9WWaJK7jA7v5Y+enzolq4nhADLotZ2EBeiAA1T 9Fon3y3M+AVm6eHLigPcFyqtXAegiK2oHAIsbiLuqUiptNjySnSQwHCxO50+skH4lKSf ySmu6W8ashWRJeSyDcC/UTHhvYftsKWkI12ZtsiLxuaEdOD6FC5IjaTbXJVVCBppL5vY ZhEu7zzoCwCaGdn5mP0FYQfERjEn0yBfl/t2aHnYR3pR+ipEZ4SxVgC3AmPUMzgeCC4a x2u6bVejejbe2I9ZVvMY9JbXxS8JdliiiKo12G0mDAQVs+quyzCDxCzRCuB9TSu6malQ TaFw== X-Gm-Message-State: AOAM533Jvhccvu5RyvuGPp2N7FszlUASP/XEqPO1LZ/tAYvyO8FKDnBO NeYNvqhK7b0cYnwTC2WKw+W1JA== X-Google-Smtp-Source: ABdhPJyuCYPX1plvyg1NbU2eTc1A/MA3rIHm9Y2GtbN7qvl+fcWRq4S6vao1xfiQxhkHc8vEMWXbrA== X-Received: by 2002:aa7:8d4c:0:b029:21c:104b:f6cb with SMTP id s12-20020aa78d4c0000b029021c104bf6cbmr20155659pfe.26.1618853967954; Mon, 19 Apr 2021 10:39:27 -0700 (PDT) Received: from [192.168.64.62] (50-78-183-178-static.hfc.comcastbusiness.net. [50.78.183.178]) by smtp.gmail.com with ESMTPSA id c23sm5393955pgj.50.2021.04.19.10.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 10:39:27 -0700 (PDT) Subject: Re: [PATCH v5 1/9] target/arm: Fix mte_checkN To: Peter Maydell References: <20210416183106.1516563-1-richard.henderson@linaro.org> <20210416183106.1516563-2-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <30e8ad67-2d14-cd1e-af8f-a4286d4571ce@linaro.org> Date: Mon, 19 Apr 2021 10:39:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/19/21 9:26 AM, Peter Maydell wrote: >> @@ -779,29 +779,27 @@ uint64_t mte_checkN(CPUARMState *env, uint32_t desc, >> >> mmu_idx = FIELD_EX32(desc, MTEDESC, MIDX); >> type = FIELD_EX32(desc, MTEDESC, WRITE) ? MMU_DATA_STORE : MMU_DATA_LOAD; >> - esize = FIELD_EX32(desc, MTEDESC, ESIZE); >> total = FIELD_EX32(desc, MTEDESC, TSIZE); >> >> /* Find the addr of the end of the access, and of the last element. */ >> - ptr_end = ptr + total; >> - ptr_last = ptr_end - esize; >> + ptr_last = ptr + total - 1; > > Code change means the comment needs updating, since we're no longer > finding two things. Change to just > /* Find the addr of the end of the access */ > > ? Yep, good catch. r~