From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70376C433DB for ; Wed, 24 Mar 2021 09:49:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AAC2619B4 for ; Wed, 24 Mar 2021 09:49:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AAC2619B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP08W-0001Kt-9Q for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 05:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP07H-0008Pl-6X; Wed, 24 Mar 2021 05:47:55 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:41686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP07F-0000l9-NX; Wed, 24 Mar 2021 05:47:54 -0400 Received: by mail-wm1-x32f.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso820896wmi.0; Wed, 24 Mar 2021 02:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yWjwqs6d404aI1hPO6hPJVKceVybdVWjxYfbshjaNXI=; b=McrjIBEEDjKpZpPT70P0buk2KLnYuyIAEW6reaU1LQ43Q6bTvdY08etC+DIPBOYXX9 w81oX2a806EtZXb/zd8NQz+DCsPzjyjQ7oQAyQSC2JOjaq959rk2043t0/0FHeUMES9Y nlJv8E8YRXIv5rTLnWF9EFcBMi1uSbSbNog3275SJOKkdOWN6yE3yx+MY+kB2ePMz4zp NSRwh8WWbJHzDp6tHEqio3Prnh6/7HECL9ugxTPPcDDXxjRpN9Tafv2lx9f8SnaExBs/ NrCUGPogk5Rld7CsgLRI9X2C+d6l9rp5SX/t+QSev7r2xhASsjGNZS9kY7NJJjWa+ffj E7VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yWjwqs6d404aI1hPO6hPJVKceVybdVWjxYfbshjaNXI=; b=oraJIm6Ffvnr/xITXAXMV5leoHodMmSvZ5OZ6PL3f3964SEBHiLOVU1GSfUaEZ6jOw wei9PZadjcawJieW/MoUtPb3XkJZLUnGB3TBRyJGsEI0EwUjJdeuhNhUXDci2tg6Okdd 1QI7hUcrQSKyp6qqyxl07nVGfObYASxFumvFIB2P7SxCFsma2Jucl9Tu1Wn9oDcWz/iV nk6vo0GMk6J+z1aoadT4E7Xd8cRn+dOQvZXIlCZpEFfvBBSLRCfaR+eV2CbdNlZ+zXMw ZgQa1jqHeGSMNg+qD/Yba5OpZSfbIxUJ9M4DJ72szDZhx0yO10mGKI+eyhjCwZFrDxYB pUQg== X-Gm-Message-State: AOAM532fZvgKoiIVymldL/1m9uSCYwNC7Ij0RMB+5jAp+YaqwE1S5vP5 4NBrMUttx+SGPgvsep56eBm9Uexvf+RKpg== X-Google-Smtp-Source: ABdhPJyq8ugrLYmSw59qE3OU+Fnnwt9Q8zq84+nvLfGioAseZfX7KEp8OGsG7ShFBu0qjTkK7aryBg== X-Received: by 2002:a1c:bc82:: with SMTP id m124mr2058624wmf.118.1616579270799; Wed, 24 Mar 2021 02:47:50 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id j136sm1747441wmj.35.2021.03.24.02.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 02:47:50 -0700 (PDT) Subject: Re: [PATCH v4 2/3] aspeed: Integrate HACE To: Joel Stanley , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= References: <20210324070955.125941-1-joel@jms.id.au> <20210324070955.125941-3-joel@jms.id.au> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <30ea65c8-ce09-c582-fe98-64315bb54e62@amsat.org> Date: Wed, 24 Mar 2021 10:47:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210324070955.125941-3-joel@jms.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/24/21 8:09 AM, Joel Stanley wrote: > Add the hash and crypto engine model to the Aspeed socs. > > Reviewed-by: Andrew Jeffery > Signed-off-by: Joel Stanley > --- > v3: Rebase on upstream > v4: Update integration for soc-specific hace objects > --- > docs/system/arm/aspeed.rst | 2 +- > include/hw/arm/aspeed_soc.h | 3 +++ > hw/arm/aspeed_ast2600.c | 15 +++++++++++++++ > hw/arm/aspeed_soc.c | 16 ++++++++++++++++ > 4 files changed, 35 insertions(+), 1 deletion(-) LGTM. Reviewed-by: Philippe Mathieu-Daudé