qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation()
@ 2021-04-06 20:28 Philippe Mathieu-Daudé
  2021-04-06 23:07 ` Richard Henderson
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-06 20:28 UTC (permalink / raw)
  To: qemu-devel
  Cc: Aurelien Jarno, Aleksandar Rikalo, Richard Henderson,
	Philippe Mathieu-Daudé

Fix a TCG temporary leak when translating CACHE opcode.

Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index c518bf3963b..71fa5ec1973 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -12804,6 +12804,8 @@ static void gen_cache_operation(DisasContext *ctx, uint32_t op, int base,
     TCGv t1 = tcg_temp_new();
     gen_base_offset_addr(ctx, t1, base, offset);
     gen_helper_cache(cpu_env, t1, t0);
+    tcg_temp_free(t1);
+    tcg_temp_free_i32(t0);
 }
 
 #if defined(TARGET_MIPS64)
-- 
2.26.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation()
  2021-04-06 20:28 [PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation() Philippe Mathieu-Daudé
@ 2021-04-06 23:07 ` Richard Henderson
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-04-06 23:07 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Aleksandar Rikalo, Aurelien Jarno

On 4/6/21 1:28 PM, Philippe Mathieu-Daudé wrote:
> Fix a TCG temporary leak when translating CACHE opcode.
> 
> Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU")
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/translate.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-06 23:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 20:28 [PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation() Philippe Mathieu-Daudé
2021-04-06 23:07 ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).