From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EEEC33CB3 for ; Tue, 14 Jan 2020 08:29:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9F8C2084D for ; Tue, 14 Jan 2020 08:29:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F8C2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irHZr-0007cY-VI for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 03:29:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49263) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irHZ8-0007BM-K5 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:28:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irHZ7-0000Qo-Ht for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:28:46 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:49081) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irHZ7-0000Qb-90 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:28:45 -0500 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MfpjF-1jJiQE0z6n-00gKPF for ; Tue, 14 Jan 2020 09:28:43 +0100 Subject: Re: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging To: qemu-devel@nongnu.org References: <20200114030138.260347-1-jkz@google.com> <20200114030138.260347-2-jkz@google.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <316a4963-a65a-4396-ef72-32358f45a4e3@vivier.eu> Date: Tue, 14 Jan 2020 09:28:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200114030138.260347-2-jkz@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:i57Nw4/oAZq+07nk/YwZFe6D28XrIx7zpw7/p37tOZQieAnhfpD uJhNfKAKjoqqDtuEFwpJZajy3sTQx9adqGFLp8RqIlyXwaM3r7FX3wxq+51ENvkElVhlptU OHgJrhA61TtoChmHGAOI18h4lRU/+iIkojH33RmuPvTjmWadHO2WwdRaoFs0wX5FH6kXSdV JLlwuSRHaui932zPYGIXg== X-UI-Out-Filterresults: notjunk:1;V03:K0:EJE7J89oov0=:fz0IN18FLiHT1e2ewjsn8P AoX/6WeK/NkIkwJecEFfHFUhetgGP0K6wNA/UjTDb0INelEBkN/1k79Hio+xq3p3nHx/SeFgU VWw59BUeHqvRc4B1vwh1m9uHrUMen/1mVO9OvmATngjUHuS4oeuV0V9n6uM92pln0NT/y027l 4nxYh65ytRy5BiuYd1rKAryFGSqesWm+jkFdJUcn934ptjCLlpvVJ67cdRpgkyzGGpGMPBx+u OWUSYaMf8EuEg/fkAjRps3VAqvDWn3hYohTAaKuxtG7b1ZkyMw/1zhxd1iMw6QEOt1cmFGRQZ qqfE35uJekje+LS+Xv1t7KrrnsjX5Qzo+ALjlZcO82Th5Ez76yf/j5ZuETxhMyO2vPkdztvCg yVpbAFJdGJ408VwMFKlLAIHiwvLsr1hXMS3UTsGJcg0kA9ofIrCiyIv6WunPbVABUgzjKmFBY iS+DEoAEAB33PvifVsC6ux65c5WvpaOOqaZyPeoJYm96IEHURN73spSpNxb6l/rdx0t4Xn/Nf abmDU5YqTTGReY6tKt94n8dcNPTOUtZYHtloKrb6jJcejDxe96LXcPQxrbVNsQrXUtpx1uu7g 2oZnk9N8sE1PRSRQHBEwv9/s69n2HGQ8lWFH/K2OILDkinZe1OiaMwpaU6DHP0GcWD6xoc9wg r8r1rrQA9cWwLJvsjmGRj9kiQCcv1MlkcjJqEveDzwHYdw1Uc/2WV0r9lBWtjs1WzNWKV13WX Xb/HYAzobcPaQr9cBrpr4/1M/LJ0jByh8yQo34kMJQryfzecb4piaksq4NiEOFONxZk7PwTz5 rntrK1u3jdUb/W4LkpfVsV0CRYTdTnpxpiNk2Bhd4Kzla4ngj+M8dTUwtc0u/aC3iGzjVmGS9 whX/pU2JLgpQ3ETUh68g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 14/01/2020 à 04:01, Josh Kunz a écrit : > This change introduces a new logging mask "LOG_USER", which is used for > masking general user-mode logging. This change also switches all non-strace > uses of `gemu_log' in linux-user/ to use `qemu_log_mask(LOG_USER, ...)' > instead. This allows the user to easily log to a file, and to mask out > these log messages if they desire. > > Signed-off-by: Josh Kunz > --- > include/qemu/log.h | 2 ++ > linux-user/arm/cpu_loop.c | 5 ++-- > linux-user/fd-trans.c | 55 +++++++++++++++++++++++++-------------- > linux-user/main.c | 24 +++++++++++++++++ > linux-user/syscall.c | 30 ++++++++++++--------- > linux-user/vm86.c | 3 ++- > util/log.c | 3 +++ > 7 files changed, 86 insertions(+), 36 deletions(-) I think most of these log messages should use LOG_UNIMP, so no need for a new flag. Thanks, Laurent