From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3080EC47076 for ; Fri, 21 May 2021 17:56:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 899FE608FE for ; Fri, 21 May 2021 17:56:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 899FE608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk9NQ-0001Ak-M9 for qemu-devel@archiver.kernel.org; Fri, 21 May 2021 13:56:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk9Iv-0000xX-RX; Fri, 21 May 2021 13:51:21 -0400 Received: from mail-eopbgr80114.outbound.protection.outlook.com ([40.107.8.114]:11393 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk9It-0006Sf-HR; Fri, 21 May 2021 13:51:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AZECX+m1VlosARS4exz/KtaHmzf8Y2UWMkE/ME+pHdtBxVYFikZZQWogigr5nSmTWUueHQy8Pv+WtBxKY2jjQM7vTczdktq8EhgkoW4njqf0PiBBlpELhX95iruFHeqJ2FKyvHlUCPWYv51ORIuPXV0Sbe6mDZiyfqb6ifriFBrkmoswusItzk4PGF5XAJWDfiNpMxchFDmzbCeXQYy7vK9rs08ooCaB1fC9mfOh1IMezPmJfAiy2OviJs19wHW0fxkY5TYZO/7mpRjqFACWdjajdYRIzoZaG9BVuvhdcFj0Cv1iwSBQ+W8s41FeFKEc4KpopQZGGKrONkqNvUCf7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVtSzq5fyeumB5/IB4AgLZO/TeeZtaYHOOLsojKUKLA=; b=EOhCE+QYoPFXk/iNzJQNOTMBPRzRqy/EIJw0AkLeJI3IYQEdMLa+K3AyA7PcyQu2AHgXzP6DRvPnJtoi/1kW80GPbbjn82A70tO1ubDn8z9wQIsAfoFx0tDeebGmexYXDFQjkxaAlAakAIShsSXjWFpac5NhShsZ6ZWUQlwZpfgxBPYdY929lTONc5m8IezVYjf8koSRuQN8ggrcfhQUAa8nduEqXGzLf63E9K4tAskRU76c/CjM/zxLARSqFGBeg9uTATZD4DqDVt0SGxJVAboiv3w3vJWxd9qEShkUyZkJdmu2D6AeXup6Crf0QM5+jjzRZtSvtxFRN0/RbsRpdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVtSzq5fyeumB5/IB4AgLZO/TeeZtaYHOOLsojKUKLA=; b=mM6lAKoyGUic4/eRIFzOFL1mD9IaHVwNGnETjgDsbvYK4dIrXvL3NYl04EU/etkqg9pvx0K1smOpDX4Ltzp54ZyvnqkTr+q+r2piAcWrGtnCVpfCWLqaGJg591Gl2D0roFFWl/BJpnRVFVP9sVGy1D+xUih8l/zmoHfrkcFnVZo= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB5911.eurprd08.prod.outlook.com (2603:10a6:20b:292::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Fri, 21 May 2021 17:51:16 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::b403:c1a9:6bb7:133]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::b403:c1a9:6bb7:133%8]) with mapi id 15.20.4150.025; Fri, 21 May 2021 17:51:16 +0000 Subject: Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write To: Paolo Bonzini , Emanuele Giuseppe Esposito , qemu-block@nongnu.org Cc: John Snow , Kevin Wolf , Max Reitz , Stefan Hajnoczi , qemu-devel@nongnu.org References: <20210518100757.31243-1-eesposit@redhat.com> <20210518100757.31243-2-eesposit@redhat.com> <5a4cc9ae-f419-ab40-cd7a-d30e39f91e54@redhat.com> From: Vladimir Sementsov-Ogievskiy Message-ID: <316e435d-2cbf-877c-cd31-adc6fe756238@virtuozzo.com> Date: Fri, 21 May 2021 20:51:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 In-Reply-To: <5a4cc9ae-f419-ab40-cd7a-d30e39f91e54@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [185.215.60.197] X-ClientProxiedBy: PR3P251CA0023.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::10) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.100.8] (185.215.60.197) by PR3P251CA0023.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.24 via Frontend Transport; Fri, 21 May 2021 17:51:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ab084fa-e197-4c07-ea27-08d91c810835 X-MS-TrafficTypeDiagnostic: AS8PR08MB5911: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:107; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PyHDKi1amYx4TqZ1vGOqCNmP2eDvYaXyDWKTQGnDqyjRbQAY119o55LqzKXcK55fv8jlbLOyZ2afHfqkb2zsk6/+rPwf4IhNv5dTquiYG7tBMqPO8VNdl6xb8a9AHnzP79CV63c7NRNvMZwT3UE8eu6RuBP6SsHbDXE4F4rmRQPYn7rrl5o6NeOjf4Wvt8hGFvKMjRZ75tnD1rwfkSMngK17Kto7cQv6ePR3cWkLwSefZNVYtVhHWlfCDN++ULWHE5nOGREIpbVfLk8NC4ohPG5Cyn/LbUeBh2DmMeXgBHMb/YSULbynDpJXyFSdDW1HcKLwwAxm2dJ2XFYrpAqWyL/NsBZVKGOonwBzKFLFnt+AcNSmHSPAW26ffuhMtnY4krnnQTk4sQwovEwRhvTjZT6g+OvfZb9urB5TbHh7sLJ2vIfM5sAJoMX4bT4ryCNhdTo1AGkj0ED0wlJomZuPtyP1vUdsEdT3XQTE9kyaNBhBlL1nfZ2fFcvyHjJnpVeMxiYumOcILmvYd87KZwLwFt4jGIlpTulR9tIpgOlmWx03CPE1GwxAV8VsTWmosnG0YNWSXP4rPFx1uCcDULjdit7rh02QhFIUzEzwxVgfTJQWlj3z5iW8CEVMKOxJpWgc4xSz+acDNMbBrq+OJivP7dOfwQ2B7RejPtfOe6sQH5/7G7+ysJVoSVzRsdF96UaWPjRdqvYpC9O0lIs1Tr4nhIHFMRileEOK48a+bdpkTsQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(396003)(376002)(39840400004)(31696002)(38100700002)(38350700002)(110136005)(86362001)(54906003)(52116002)(31686004)(478600001)(36756003)(316002)(2616005)(16576012)(956004)(4326008)(8676002)(5660300002)(4744005)(26005)(83380400001)(8936002)(66476007)(66946007)(66556008)(186003)(2906002)(16526019)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZlNVRDQrQkdUVGNKWk5UZ0VBRXJGcEdZSHVYbkdieS9KazYyTjI0b2hudlFo?= =?utf-8?B?RW04UEJtVVBSQjNnTG85NnkybFloYkFKS0V5amtMUVF0emJtV2U3b0tLaWN3?= =?utf-8?B?bjc0THFsWlk0MjVHdUFXS2s4R3E1ckY5SHhQTkxtcklHdnBGOGp4TXJBeUd2?= =?utf-8?B?Q0RwaGFYenA1UlhpaUM3eWl5Ymtuc3JXdm4zTzVaczE2WXgyN3JBeGNXWnJT?= =?utf-8?B?Qk82Ni9zenBGdm5seU9PckI0c0Y0YmE0bE50ZXFsRXBhNVlwVTdUcFVxbVox?= =?utf-8?B?Tit5S3c2WXUzT01RTHlPT2lTc2NDUXN0VWtPZjA5SjdsTFBpTnA2dTJRbExx?= =?utf-8?B?Nk1zYnV2S3g5Q0xTd05taGpUMytyMTlPNWFRUGxFYzREUVZZc296a2NweHZS?= =?utf-8?B?bE5JVkI4YlFUeEZIckg2S1lhcDhCRkdXZ2NmU05wM1ZWSktwVElnbHoyVVZJ?= =?utf-8?B?ZkYrODJQNXRubmt3eWM2cWljckllVVIvTEpUQnZEbWFqY3VBZmZSUlRJdzhh?= =?utf-8?B?MnNSTUFaTWtkZ1dGNGZVMUlFYTF3Mkp0ZFpUU3Fpcm9UV1cyWEJsSHQ4eGVw?= =?utf-8?B?d2xnbHorMTRWR2Y4T3NqcDdhaTYzR2FWck1ZSXpHWUlMTlJ5cDg3QWhVL0Nh?= =?utf-8?B?QW5RUE0yM0w4TkZjVmRIYXAyNkU5bUxHU1JDYkFuVEw2R0pZZ2ZoU3FaV1gr?= =?utf-8?B?eEdHaFB6Mm92R1JxYVZJS1Fub3lnNmkwZWptK0JoZ1Rva2p3ZmZaZGlObFpZ?= =?utf-8?B?bFB4Q2FMTHJsQWZPcVc5TXE1a1ZHa2lSc3gvQXF1bGE2Q1BXbzhiVERxY0Vx?= =?utf-8?B?RENsQUorY0d2dkE4RjBFT0JCbkZYbUR4MkZiUDdma2lWa09BQmt3RXhBVFJw?= =?utf-8?B?Q09DWjlCZlZJMXJSOHR5Rm55djdQakpxeWVUYkpuc09hbk1OaUlLQTNoRHIx?= =?utf-8?B?c0U1eG5Fa29KZGhSVzd1a0thcXQrRlpwSEVKWFh1YkZ4cHUxNGNpMHZGYWI0?= =?utf-8?B?SUJtQVJHSW5hOXVVQi9FRCs4QkF5R213MHJtWWRLTFNMd2NleWxBbzZEVndX?= =?utf-8?B?M1VSUjdFUUZ0YTFUU3NCR2xIeVhac1hQeVpRckFuUXFEK2xkcjI4OUFwZkc5?= =?utf-8?B?ampQR0ZTaE92R3QzczFYRk1LaERtWDVPWG8zVFh5dWZ4aGlNeGRha2htSUVq?= =?utf-8?B?bDBzRXhHcFY5L1BNWVRoQ05RV0w0SU9PU2VtMjBwd1p3eXQ5Vno3SVBEbUU3?= =?utf-8?B?ZktsT0hJcDNQbGhjSzB0V0NlV0hKR3RJVXhIdHBZZStqa0VJL01xbG9qem1Y?= =?utf-8?B?YXM2cDVROFEyV2JGY3N3aElOUUVYVHFTTGltN2k4Nm1lZVdwMHRGMHdZeEtE?= =?utf-8?B?b2hqeTB6Y09TMEQzUzFxdjNuNXZpbmlJcDdibEQ2YUsyNWxmTG91aU9VSDEv?= =?utf-8?B?TDF3L2EzRjlDYXB2Qk9tVmk1Ynk4a1BhSEI1WWxDSHNqY3I0Znlad0s0eDhO?= =?utf-8?B?eUFOOXF5QStZUzVtTG1nMVk4dXR1aFBET0ZwVlI1RVFMOFZ0cEtTWFdtbUIr?= =?utf-8?B?M3lwTHk3S3NIVGs0U3U0U3hkV2FZU3RPZUdQbm0zcC9BRW1kTkFLQkpNS0hh?= =?utf-8?B?Y2Faa1Q2SGZUTmhvWC9rbUNMVG9QVHkzaHFUL2wxaHFIQmdkWk5tTUl0aXRO?= =?utf-8?B?eTN4ZVZKc01Bd1l2R2FSMTE0RUtnbFhYZ3JLK0pOUGFZRmR0MWR6ME9iUk5B?= =?utf-8?Q?zMrQhYR6YebeF2vpkhKdThdu+HB3QX2o6DzyCPe?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab084fa-e197-4c07-ea27-08d91c810835 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2021 17:51:16.4841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WRrZAOK0Q0BbbwuzsdZ6eBHVO/k9H40oOHItaD+DptmufdGM7sRBFHf5SWwbkW+c+4pmFthKr0iGJgnU7Aqg8Caq+qhSx4lCPRPbAzIGL2I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5911 Received-SPF: pass client-ip=40.107.8.114; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 21.05.2021 18:10, Paolo Bonzini wrote: > Stats don't say everything.  Not having something like this: > >                 s->copy_size = >                         MIN(MAX(s->cluster_size, BLOCK_COPY_MAX_COPY_RANGE), >                             QEMU_ALIGN_DOWN(block_copy_max_transfer(s->source, >                                                                     s->target), >                                             s->cluster_size)); Yes, this one always looked bad.. -- Best regards, Vladimir