From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Reza Arbab <arbab@linux.ibm.com>
Cc: Daniel Henrique Barboza <danielhb@linux.ibm.com>,
Leonardo Augusto Guimaraes Garcia <lagarcia@linux.ibm.com>,
Greg Kurz <groug@kaod.org>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs
Date: Thu, 16 Jul 2020 13:40:19 -0300 [thread overview]
Message-ID: <326ed981-5a8c-0ef2-5b88-a893a53956cd@gmail.com> (raw)
In-Reply-To: <20200716160017.jw27huiqs2ghk4c4@arbab-vm>
On 7/16/20 1:00 PM, Reza Arbab wrote:
> On Thu, Jul 16, 2020 at 06:42:11AM -0300, Daniel Henrique Barboza wrote:
>> Which would translate here to:
>>
>> uint32_t associativity[] = {
>> cpu_to_be32(0x4),
>> cpu_to_be32(nvslot->numa_id),
>> cpu_to_be32(nvslot->numa_id),
>> cpu_to_be32(nvslot->numa_id),
>> cpu_to_be32(nvslot->numa_id),
>> };
>
> Sure, that's how it originally was in v1 of the patch.
Yeah, Greg commented this in v2 about this chunk:
------------
This is a guest visible change. It should theoretically be controlled
with a compat property of the PHB (look for "static GlobalProperty" in
spapr.c). But since this code is only used for GPU passthrough and we
don't support migration of such devices, I guess it's okay. Maybe just
mention it in the changelog.
--------------
By all means you can mention in changelog/code comment why the associativity
of the GPU is nvslot->numa_id 4 times in a row, but I believe this
format is still clearer for us to understand. It also makes it equal
to skiboot.
And it deprecates the SPAPR_GPU_NUMA_ID macro, allowing us to use its value
(1) for other internal purposes regarding NUMA without collision with the
GPU semantics.
Thanks,
DHB
>
> I'll send a v4 today. It's been a while so I need to rebase anyway.
>
prev parent reply other threads:[~2020-07-16 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 19:53 [PATCH v3] spapr: Add a new level of NUMA for GPUs Reza Arbab
2020-05-22 20:08 ` Reza Arbab
2020-05-25 5:06 ` David Gibson
2020-05-25 5:05 ` David Gibson
2020-05-25 17:49 ` Reza Arbab
2020-07-16 5:04 ` David Gibson
2020-07-16 9:42 ` Daniel Henrique Barboza
2020-07-16 16:00 ` Reza Arbab
2020-07-16 16:40 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=326ed981-5a8c-0ef2-5b88-a893a53956cd@gmail.com \
--to=danielhb413@gmail.com \
--cc=arbab@linux.ibm.com \
--cc=danielhb@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lagarcia@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).