From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08659C47404 for ; Fri, 11 Oct 2019 07:59:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD67320679 for ; Fri, 11 Oct 2019 07:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD67320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIppe-00018q-UZ for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 03:59:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38452) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIpnY-00087w-P3 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIpnX-0002O7-OW for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:57:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39906) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIpnV-0002Mb-Hu; Fri, 11 Oct 2019 03:57:13 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF50EC05AA56; Fri, 11 Oct 2019 07:57:12 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3ACF5D9DC; Fri, 11 Oct 2019 07:57:10 +0000 (UTC) Subject: Re: [PATCH 04/23] iotests: Filter $SOCK_DIR To: Eric Blake , qemu-block@nongnu.org References: <20191010152457.17713-1-mreitz@redhat.com> <20191010152457.17713-5-mreitz@redhat.com> <727638b4-8588-76eb-1428-9b2a9a8df380@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <333ea7f7-ee1c-16d3-0f1e-9828686e97a5@redhat.com> Date: Fri, 11 Oct 2019 09:57:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <727638b4-8588-76eb-1428-9b2a9a8df380@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YfgGrC6pwV1dC57VhgCXFqTtlHiTnuqav" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 11 Oct 2019 07:57:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --YfgGrC6pwV1dC57VhgCXFqTtlHiTnuqav Content-Type: multipart/mixed; boundary="lQ6ohhLSZzi0lKpxeI83Im2sYSdkUuIfx" --lQ6ohhLSZzi0lKpxeI83Im2sYSdkUuIfx Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10.10.19 21:50, Eric Blake wrote: > On 10/10/19 10:24 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> =C2=A0 tests/qemu-iotests/common.filter | 8 ++++++-- >> =C2=A0 1 file changed, 6 insertions(+), 2 deletions(-) >> >=20 >> @@ -218,7 +221,8 @@ _filter_nbd() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Filter out the TCP port number since = this changes between runs. >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $SED -e '/nbd\/.*\.c:/d' \ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -e 's#127\.0\.0= \.1:[0-9]*#127.0.0.1:PORT#g' \ >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -e "s#?socket=3D$TEST_DIR#= ?socket=3DTEST_DIR#g" \ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -e "s#?socket=3D$SOCK_DIR#= ?socket=3DTEST_DIR#g" \ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -e "s#?socket=3D$SOCK_DIR#= ?socket=3DSOCK_DIR#g" \ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -e 's#\(foo\|PO= RT/\?\|.sock\): Failed to .*$#\1#' >=20 > This goes away in 23, but this looks crazy.=C2=A0 Don't you really want= the > first line to replace $TEST_DIR with TEST_DIR (not $SOCK_DIR with > TEST_DIR)?=C2=A0 Otherwise, bisection is likely to break until all the > intermediate patches have made the conversion to stop using TEST_DIR. >=20 > I already gave R-b, but you'll need to fix this one. Oops, yes. I messed it up. I only intended to add the SOCK_DIR replacement line. (Originally I had 23 merged into this one, and then I noticed it would break bisection, so I tried to pull it out. And failed, as you can see.)= Max --lQ6ohhLSZzi0lKpxeI83Im2sYSdkUuIfx-- --YfgGrC6pwV1dC57VhgCXFqTtlHiTnuqav Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl2gNdUACgkQ9AfbAGHV z0DL4Qf+ILS8dO9D5tQpCjkNxtD9sSLeALgjADnZc+DeF6heZ0kRA1O+ESSgBH52 WFceQk9nYdGBmSFsRVi14eMNVRUyQ5+Vkf1gKpI/MZYZpkFUFILZZWw76f17DoRp /gbs62lMeSI04S2Wa2vjvwNvCkAQbTx3v6FzSyEw45w4kGTJl0sZvl8ok/3DXS4E U/is5fFvT5J9OkgUurAKA7KNm9pIJANbH4EU205cWMpR57XgA2BruRL2FI7CJQAN jIAc4pXKsuwNAhZeNnVsA76I4SPA36wwbZPnEY1W/yB1OOwDho1Jn6QSKo5dLJ9+ 7tDap479d+hFfAYP9BXgLW+/pifU7w== =S3wQ -----END PGP SIGNATURE----- --YfgGrC6pwV1dC57VhgCXFqTtlHiTnuqav--