On 11/28/19 6:34 PM, Cornelia Huck wrote: > On Wed, 27 Nov 2019 19:38:06 +0100 > Janosch Frank wrote: > >> On 11/27/19 7:25 PM, Janosch Frank wrote: >>> >>> There's 0 (initiated), busy and operational and as far as I know we >>> implement neither. >> >> That came out wrong... >> s/operational/not operational/ >> >> We only implement "command initiated" / cc = 0 >> We can never have busy, because we handle sclp calls synchronously. >> The spec does not give any indication when we could return "not >> operational". I guess that's just a free pass for hypervisors. > > Regardless, setcc(cpu, r) also feels a bit cleaner to me... Ok, do you want to change that while picking the patches up or shall I send a new version? > >> >>> sclp_service_call() returns either 0 or -PGM_CODE, so we don't need to >>> check when we're after the pgm injection code. >> >> >