From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Fam Zheng <fam@euphon.net>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports
Date: Fri, 20 Sep 2019 13:34:46 -0400 [thread overview]
Message-ID: <34b9441e-824b-d6e7-903f-e04cd1cd178e@redhat.com> (raw)
In-Reply-To: <4bf8c4ed-806e-6ee8-0031-5ce43dc52803@redhat.com>
On 9/20/19 12:28 PM, Philippe Mathieu-Daudé wrote:
> On 9/20/19 6:23 PM, Philippe Mathieu-Daudé wrote:
>> On 9/20/19 6:20 PM, Alex Bennée wrote:
>>> John Snow <jsnow@redhat.com> writes:
>>>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote:
>>>>> On 9/20/19 2:14 AM, John Snow wrote:
>>>>>> These are listed as "partial" images, but have no user.
>>>>>> Remove them.
>>>>>
>>>>> Well, I have WiP users from them. I could restore this content when they
>>>>> are ready... Ports is the base of deprecated Debian archs. On the other
>>>>> side Sid is the base for edge development I use from time to time to
>>>>> test latest gcc/binutils.
>>>>> I'll try to find time to raise WiP branches to PoC.
>>>>>
>>>>
>>>> I think that's the right thing to do. Right now, the docker tests
>>>> directory has a lot of stale entries and unusable tests. That might be
>>>> fine for the people working on it, but it makes it hard to understand
>>>> and use for those of us who only occasionally traipse into the directory.
>>>>
>>>> I'm removing all references to python2 -- but if there's no way for me
>>>> to test debian-sid and debian-ports, I can't test changes I need to make
>>>> to these "partial images", so they should be removed until they are
>>>> consumable.
>>>>
>>>> While I am sympathetic to the idea of having a library of partial images
>>>> to use for future tests, they're prone to rot if there's no way to
>>>> exercise them in-tree.
>>>
>>> Don't forget some "partial" images are only used for building TCG tests
>>> - we want to keep them. But as git is forever I can drop the sid/ports
>>> stuff for now until Phillipe has something to use them again.
>>
>> For Sid I have this case:
>>
>> -- >8 --
>> #
>> # Docker Renesas RX cross-compiler target
>> #
>> # This docker target builds on the debian Sid base image.
>> #
>> # Copyright (c) 2019 Philippe Mathieu-Daudé
>> #
>> # SPDX-License-Identifier: GPL-2.0-or-later
>> #
>> FROM qemu:debian-sid
>
> Oh well nevermind it is old, so it probably now works with debian-10.
>
> I used the Ports base for sparc32 and x32, I don't have them on my
> workstation I'll check during the WE.
>
If you want to keep docker-sid as a partial image for possible future
uses, you might consider adding a simple amd64 user -- debian-sid-amd64
would suffice.
It doesn't have to do anything interesting, but it exists to give
debian-sid a user.
I'd rather not waste your hard work, but I am making a plea that any
images defined in the tree can be tested by running tests that use them.
--js
next prev parent reply other threads:[~2019-09-20 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 0:14 [PATCH 0/3] docker: misc cleanups John Snow
2019-09-20 0:14 ` [PATCH 1/3] docker: remove 'deprecated' image definitions John Snow
2019-09-20 0:14 ` [PATCH 2/3] docker: remove debian8-mxe definitions John Snow
2019-09-20 0:14 ` [PATCH 3/3] docker: remove unused debian-sid and debian-ports John Snow
2019-09-20 8:49 ` Philippe Mathieu-Daudé
2019-09-20 16:10 ` John Snow
2019-09-20 16:20 ` Alex Bennée
2019-09-20 16:23 ` Philippe Mathieu-Daudé
2019-09-20 16:28 ` Philippe Mathieu-Daudé
2019-09-20 17:34 ` John Snow [this message]
2019-09-20 16:30 ` Alex Bennée
2019-09-20 17:24 ` John Snow
2019-09-20 21:19 ` Alex Bennée
2019-09-20 21:32 ` John Snow
2019-09-21 9:53 ` Philippe Mathieu-Daudé
2019-09-23 17:22 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34b9441e-824b-d6e7-903f-e04cd1cd178e@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).