From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AA4C433DF for ; Fri, 3 Jul 2020 07:25:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F4FC20656 for ; Fri, 3 Jul 2020 07:25:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="adRHvHSP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F4FC20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrG4o-0002XM-EJ for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 03:25:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrG3s-0001p8-Jr for qemu-devel@nongnu.org; Fri, 03 Jul 2020 03:24:40 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:31099 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jrG3r-0006eg-6L for qemu-devel@nongnu.org; Fri, 03 Jul 2020 03:24:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593761078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ssJgYySuxKDbd5Lo9CjCfCNpIzX9m98uXZqwJ+zuNAs=; b=adRHvHSPKi0Lhajo/63mQxk3i/B7Q0guLmXQse6VY/UnLBt7JYCMt6ZBEch1QHeHAQWScZ IZC3gBRHONO3Zv+vsQi9nzT15SOxVCqtpxGQqoSDSNEBLLviMepe0XNqrMZUyb7B5X2BUQ sJgGzRPYY0gkAKUkOITSKYT/n/tbsA0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-bf4jHlieOyq11Bblzb_DhA-1; Fri, 03 Jul 2020 03:24:37 -0400 X-MC-Unique: bf4jHlieOyq11Bblzb_DhA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E90B9107ACCD; Fri, 3 Jul 2020 07:24:35 +0000 (UTC) Received: from [10.72.13.231] (ovpn-13-231.pek2.redhat.com [10.72.13.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEA2A7923E; Fri, 3 Jul 2020 07:24:20 +0000 (UTC) Subject: Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier To: Peter Xu References: <20200626064122.9252-2-eperezma@redhat.com> <20200626212917.GD175520@xz-x1> <8cf25190-53e6-8cbb-372b-e3d4ec714dc5@redhat.com> <20200628144746.GA239443@xz-x1> <54d2cdfd-97b8-9e1d-a607-d7a5e96be3a1@redhat.com> <20200629133403.GA266532@xz-x1> <2589d0e9-cc5b-a4df-8790-189b49f1a40e@redhat.com> <20200630153911.GD3138@xz-x1> <69f6d6e7-a0b1-abae-894e-4e81b7e0cc90@redhat.com> <20200702154540.GI40675@xz-x1> From: Jason Wang Message-ID: <34fe0e55-c0ae-8e56-462b-6281b6cca4f5@redhat.com> Date: Fri, 3 Jul 2020 15:24:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702154540.GI40675@xz-x1> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 01:34:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Yan Zhao , "Michael S. Tsirkin" , "libvir-list@redhat.com" , Juan Quintela , qemu-devel@nongnu.org, =?UTF-8?Q?Eugenio_P=c3=a9rez?= , Eric Auger , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/7/2 下午11:45, Peter Xu wrote: > On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: >> So I think we agree that a new notifier is needed? > Good to me, or a new flag should be easier (IOMMU_NOTIFIER_DEV_IOTLB)? That should work but I wonder something as following is better. Instead of introducing new flags, how about carry the type of event in the notifier then the device (vhost) can choose the message it want to process like: static vhost_iommu_event(IOMMUNotifier *n, IOMMUTLBEvent *event) { switch (event->type) { case IOMMU_MAP: case IOMMU_UNMAP: case IOMMU_DEV_IOTLB_UNMAP: ... } Thanks >