From: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, lucas.araujo@eldorado.org.br,
luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br,
qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br,
david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic
Date: Fri, 30 Apr 2021 11:35:36 -0300 [thread overview]
Message-ID: <35bc4efd-bc56-f726-b0dc-b99e35f7642d@eldorado.org.br> (raw)
In-Reply-To: <27263531-91ed-b051-ca43-b105ec44d19e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
On 30/04/2021 01:25, Richard Henderson wrote:
> On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
>> @@ -49,7 +54,12 @@ static inline void vscr_init(CPUPPCState *env,
>> uint32_t val)
>> {
>> /* Altivec always uses round-to-nearest */
>> set_float_rounding_mode(float_round_nearest_even,
>> &env->vec_status);
>> - helper_mtvscr(env, val);
>> + /*
>> + * This comment is here just so the project will build.
>> + * The current solution is in another patch and will be
>> + * added when we figure out an internal fork of qemu
>> + */
>> + /* helper_mtvscr(env, val); */
>> }
>
> (1) this is a separate change to splitting out cpu_init.c.
Oh, yeah. I was going to remove this change for now, it was for building
with disable-tcg, which is still not working
> (2) you can't even do this without introducing a regression.
The plan is to not just remove, but change with a common function. on a
future series, though.
I'm just slightly concerned now that make check has not seen anything...
>
>
> r~
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
[-- Attachment #2: Type: text/html, Size: 2633 bytes --]
next prev parent reply other threads:[~2021-04-30 14:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 16:21 [PATCH v2 0/7] target/ppc: untangle cpu init from translation Bruno Larsen (billionai)
2021-04-29 16:21 ` [PATCH v2 1/7] target/ppc: move opcode table logic to translate.c Bruno Larsen (billionai)
2021-04-30 3:13 ` Richard Henderson
2021-04-30 4:18 ` David Gibson
2021-04-29 16:21 ` [PATCH v2 2/7] target/ppc: Created !TCG SPR registration macro Bruno Larsen (billionai)
2021-04-29 20:02 ` Fabiano Rosas
2021-04-29 16:21 ` [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks Bruno Larsen (billionai)
2021-04-29 20:42 ` Fabiano Rosas
2021-04-30 3:33 ` Richard Henderson
2021-04-30 4:21 ` David Gibson
2021-04-30 13:02 ` Bruno Piazera Larsen
2021-05-03 3:54 ` David Gibson
2021-04-29 16:21 ` [PATCH v2 4/7] target/ppc: turned SPR R/W callbacks not static Bruno Larsen (billionai)
2021-04-29 20:52 ` Fabiano Rosas
2021-04-30 3:40 ` Richard Henderson
2021-04-30 17:26 ` Bruno Piazera Larsen
2021-04-30 4:34 ` Richard Henderson
2021-04-29 16:21 ` [PATCH v2 5/7] target/ppc: removed VSCR from SPR registration Bruno Larsen (billionai)
2021-04-29 16:21 ` [PATCH v2 6/7] target/ttc: renamed SPR registration functions Bruno Larsen (billionai)
2021-04-30 3:52 ` Richard Henderson
2021-04-29 16:21 ` [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic Bruno Larsen (billionai)
2021-04-29 21:23 ` Fabiano Rosas
2021-04-30 17:12 ` Bruno Piazera Larsen
2021-04-30 17:42 ` Richard Henderson
2021-04-30 4:25 ` Richard Henderson
2021-04-30 14:35 ` Bruno Piazera Larsen [this message]
2021-04-30 3:12 ` [PATCH v2 0/7] target/ppc: untangle cpu init from translation Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35bc4efd-bc56-f726-b0dc-b99e35f7642d@eldorado.org.br \
--to=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).