From: Laurent Vivier <laurent@vivier.eu>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/m68k: Allow movec only on 68010+
Date: Fri, 1 May 2020 16:02:49 +0200 [thread overview]
Message-ID: <36b52da5-52f3-cc6e-8e76-36646e74c0e0@vivier.eu> (raw)
In-Reply-To: <alpine.BSF.2.22.395.2005011511210.62443@zero.eik.bme.hu>
Le 01/05/2020 à 15:11, BALATON Zoltan a écrit :
> Ping?
I sent a comment:
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html
Thanks,
Laurent
>
> On Tue, 14 Jan 2020, BALATON Zoltan wrote:
>> The movec opcode does not exist on 68000 and should raise an
>> exception. Fix the feature mask to only allow movec on newer 68k CPUs.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> target/m68k/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
>> index fcdb7bc8e4..f19da064c8 100644
>> --- a/target/m68k/translate.c
>> +++ b/target/m68k/translate.c
>> @@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
>> BASE(stop, 4e72, ffff);
>> BASE(rte, 4e73, ffff);
>> INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
>> - INSN(m68k_movec, 4e7a, fffe, M68000);
>> + INSN(m68k_movec, 4e7a, fffe, FPU);
>> #endif
>> BASE(nop, 4e71, ffff);
>> INSN(rtd, 4e74, ffff, RTD);
>>
next prev parent reply other threads:[~2020-05-01 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 20:13 [PATCH] target/m68k: Allow movec only on 68010+ BALATON Zoltan
2020-01-14 20:50 ` Laurent Vivier
2020-05-01 13:11 ` BALATON Zoltan
2020-05-01 14:02 ` Laurent Vivier [this message]
2020-05-02 1:38 ` BALATON Zoltan
2020-05-02 14:55 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b52da5-52f3-cc6e-8e76-36646e74c0e0@vivier.eu \
--to=laurent@vivier.eu \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).