From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E457C433EF for ; Fri, 17 Dec 2021 10:34:53 +0000 (UTC) Received: from localhost ([::1]:52878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myAZf-0002n3-3Z for qemu-devel@archiver.kernel.org; Fri, 17 Dec 2021 05:34:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myAYI-0001Tg-TY; Fri, 17 Dec 2021 05:33:26 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:55425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myAYH-0003RF-9m; Fri, 17 Dec 2021 05:33:26 -0500 Received: from [192.168.100.1] ([82.142.30.186]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MmkfQ-1mFidv2HQc-00jqGG; Fri, 17 Dec 2021 11:33:09 +0100 Message-ID: <372de133-599a-3948-0697-feca24611f75@vivier.eu> Date: Fri, 17 Dec 2021 11:33:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] hw/net/allwinner_emac: Replace MII_ANAR_TX -> MII_ANLPAR_TX definition Content-Language: fr To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20211122105145.1053455-1-f4bug@amsat.org> <60230067-bf75-0352-d5d6-93529c03aa24@amsat.org> From: Laurent Vivier In-Reply-To: <60230067-bf75-0352-d5d6-93529c03aa24@amsat.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:HWkhplR2HDexheGWILxeydhYny8rFKm5x2NbBpjlNWQGPBQVg9e 2zZg2Qt26rTxNyTTNltlmFsfxEWFSsVUOm4obNt6t9w/el/Ql+unCrMiB3QxcRuVO5StNCB 8WFRA83m/9vc9WxFQVWoiRQT8f1W0/2fJjR7Ij/UdVKYfGEB1lGr4kbwfL0R6CQT7IWfVgO 24AGdo4B7JLF7i4RPtdHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:aMHc+MaJYaA=:tYNbEg6FeHArvq/rVpJYpq PhoHD9SUXyPoeTcRP0JnHKxGVfl7RTNNq82UD3O8TQGWy4iINavNsNfzZS0H4xFPvh7junLSo P9JznFEoVFZkAUs5WUdtEGZvIg56qG1VQ5LZxwB/839sD68xMkMQHpB6xauWiClkdF3zfq8Yu /JOiyhryI8Qh5/dQkzqddmWVugZrXuQs7M+1y61YTNluvo6ULIBzUpVIMHMkBUXrqyKgEBhPY yi/0fOsjIjdWcWidJQI4UFYOGxS3PAo5+5Sahc/JwDsmw4k8x3cyZgM2DG4ryiROp1brfPYXd h5gehnhBdcte7d7wfGtNEARUp+1w98YjvY+dQvcAloXdth1zftwGQQN0vZESZLoQ2LlEIuXIK H3ou6oJndVq4omEuWILiHQjBmw4JKe8NcbwnFAVymzHe525aXBtGMVT4+D0lIMB7MtDjyUhOR 9i3ffXnWoWbLTncHw1nlXMbbGg89AmdOCre1uR5tNd2w51R6N+jlHq+h8HVvkq12idVxVwZ60 XcjRS7sKjqO9pM6Nacnlx/w28pG9uuUXN/lO2TcuoAv17pM4r8J+oW/1rv/I0pjvwiGXIJa/g imjmQsyOis2mogfvq70P4my4SjHfPemItTD9ou3Co3p8hI6xiArtz3pfuDncjD4pw8q2X42+6 U7h0K9B0H4wle1y8ZYZGjT1yCx14plJprUrrVb9Leb2YdZGkqBGOnT0bvadxeCn80CaE= Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.716, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , Jason Wang , qemu-arm@nongnu.org, Beniamino Galvani Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 15/12/2021 à 11:24, Philippe Mathieu-Daudé a écrit : > Ping? > > On 11/22/21 11:51, Philippe Mathieu-Daudé wrote: >> While both MII_ANAR_TX / MII_ANLPAR_TX have the same value, >> the ANAR and ANLPAR registers are different, so technically >> the ANLPAR register have to use the MII_ANLPAR_TX definition. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/net/allwinner_emac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c >> index ddddf35c45d..3aed92b8f1a 100644 >> --- a/hw/net/allwinner_emac.c >> +++ b/hw/net/allwinner_emac.c >> @@ -50,7 +50,7 @@ static void mii_reset(RTL8201CPState *mii, bool link_ok) >> MII_BMSR_10T_HD | MII_BMSR_MFPS | MII_BMSR_AUTONEG; >> mii->anar = MII_ANAR_TXFD | MII_ANAR_TX | MII_ANAR_10FD | MII_ANAR_10 | >> MII_ANAR_CSMACD; >> - mii->anlpar = MII_ANAR_TX; >> + mii->anlpar = MII_ANLPAR_TX; >> >> mii_set_link(mii, link_ok); >> } >> > There are other uses of anlpar with MII_ANAR_XXX values: 34 static void mii_set_link(RTL8201CPState *mii, bool link_ok) 35 { 36 if (link_ok) { 37 mii->bmsr |= MII_BMSR_LINK_ST | MII_BMSR_AN_COMP; 38 mii->anlpar |= MII_ANAR_TXFD | MII_ANAR_10FD | MII_ANAR_10 | 39 MII_ANAR_CSMACD; 40 } else { 41 mii->bmsr &= ~(MII_BMSR_LINK_ST | MII_BMSR_AN_COMP); 42 mii->anlpar = MII_ANAR_TX; 43 } 44 } Thanks, Laurent