From: "Cédric Le Goater" <clg@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>, groug@kaod.org
Cc: aik@ozlabs.ru, lvivier@redhat.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size()
Date: Mon, 2 Dec 2019 19:18:52 +0100 [thread overview]
Message-ID: <375755db-f76f-508b-6b8e-f8ae19d83aff@kaod.org> (raw)
In-Reply-To: <20191129013504.145455-2-david@gibson.dropbear.id.au>
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index c77f9848ec..09b3bd6443 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2101,7 +2101,7 @@ void kvmppc_hint_smt_possible(Error **errp)
>
>
> #ifdef TARGET_PPC64
> -uint64_t kvmppc_rma_size(uint64_t current_size, unsigned int hash_shift)
> +uint64_t kvmppc_vrma_limit(unsigned int hash_shift)
> {
> struct kvm_ppc_smmu_info info;
> long rampagesize, best_page_shift;
> @@ -2128,8 +2128,7 @@ uint64_t kvmppc_rma_size(uint64_t current_size, unsigned int hash_shift)
> }
> }
>
> - return MIN(current_size,
> - 1ULL << (best_page_shift + hash_shift - 7));
> + return 1ULL << (best_page_shift + hash_shift - 7));
The closing ')' should be removed.
C.
next prev parent reply other threads:[~2019-12-02 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 1:35 [for-5.0 0/4] Fixes for RMA size calculation David Gibson
2019-11-29 1:35 ` [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size() David Gibson
2019-12-02 7:45 ` Cédric Le Goater
2019-12-02 8:55 ` Greg Kurz
2019-12-02 18:18 ` Cédric Le Goater [this message]
2019-12-10 3:58 ` David Gibson
2019-12-03 3:32 ` Alexey Kardashevskiy
2019-11-29 1:35 ` [for-5.0 2/4] spapr: Don't attempt to clamp RMA to VRMA constraint David Gibson
2019-12-03 3:33 ` Alexey Kardashevskiy
2019-11-29 1:35 ` [for-5.0 3/4] spapr: Clean up RMA size calculation David Gibson
2019-12-03 3:44 ` Alexey Kardashevskiy
2019-12-03 5:06 ` Alexey Kardashevskiy
2019-12-10 5:44 ` David Gibson
2019-12-10 5:29 ` David Gibson
2019-11-29 1:35 ` [for-5.0 4/4] spapr: Correct clamping of RMA to Node 0 size David Gibson
2019-12-03 4:18 ` Alexey Kardashevskiy
2019-12-10 5:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375755db-f76f-508b-6b8e-f8ae19d83aff@kaod.org \
--to=clg@kaod.org \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).