From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB8CC3A5A3 for ; Tue, 27 Aug 2019 05:00:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5DB2217F5 for ; Tue, 27 Aug 2019 05:00:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a8G95aiW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5DB2217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Tax-00089H-O6 for qemu-devel@archiver.kernel.org; Tue, 27 Aug 2019 01:00:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2TaA-0007jq-E8 for qemu-devel@nongnu.org; Tue, 27 Aug 2019 00:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2Ta9-0005ft-9B for qemu-devel@nongnu.org; Tue, 27 Aug 2019 00:59:50 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:33924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2Ta8-0005fF-VZ for qemu-devel@nongnu.org; Tue, 27 Aug 2019 00:59:49 -0400 Received: by mail-pg1-x542.google.com with SMTP id n9so11940376pgc.1 for ; Mon, 26 Aug 2019 21:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zI/uto9yxNnWrFZoRkgTLQ8QKcp/Nqa91bO4oFtL9fk=; b=a8G95aiW7qxrfs64PVcYOMykLJ9lbCTV6JxU/QKvVQmfCkOmwf0ww4XsvxF8KIsWzK Gw6UZ0M0k/wUdTl/kQ3AWGwtbRWcxJ7gcWW0+IsJiIo2Q7MsydwjjlriDeVN/7Wx9pNI Pp5FUvY1aURhj1z1sjqQZnLDzQXWHL/l2x+aB4uw+44/6Wh5emrpRl0ZNrS0Zn0lbCV9 6HR9+mixjUqL2JcXbxvm4YZCr25ZAX77T4zGxkn7yJH2+Ww57sfv+viNG6/d8Y07imLF c2xOcPQksABdI0w9kMH6HKls3nbSsWGgUZbsaORRrSJwmYg4vWLj4VD60sdGYGdboAAB t9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zI/uto9yxNnWrFZoRkgTLQ8QKcp/Nqa91bO4oFtL9fk=; b=KVDpUqLVKA0APZsdYFJpTebNe6Ov8L59RXpeJTfLvYOqxO3MuKW4XRxda51BDwFP4U MglzNsPfCZmSjvvzslZ8zYbV8yF5FEYWdhEVxmh0NFut1GzkaoXIgcMEO/rw/+CeZj4B Ytzcbrbaa1VW65XfQlY6qPPbjgasTB2lmfEYh3rP4F2QDMpmOwRRWDkNQg/dC8ScKJXG aGZkM/+GqdL8ORcgCPSeSfH8CuusUJMFAVe6rpPZU7IHNCvt/FuZgphSG6MxzOEItHV4 9cdswLNaLBzntpUAnlcjEAckzEt3XAJ8TBSAyID5xKK7+lcDkHsLu3P6wJ1yA5ige1U+ GQ4Q== X-Gm-Message-State: APjAAAVSXqPbbSvU71+mdjckRsVKXgSaYNcpGhv0Izw3+wb/oHHvS2TY iKjo6Ln+kYRXu0BlEZR0WYMcWVdmWws= X-Google-Smtp-Source: APXvYqyzBdDyW7e4iLq3nKDBDnFJz9h6dnlhBkg27tazEsbyl6gDRj4nLUm5tdEsbsHdGPHF3dBZvA== X-Received: by 2002:a63:e14d:: with SMTP id h13mr19504020pgk.431.1566881987162; Mon, 26 Aug 2019 21:59:47 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id v22sm11231209pgk.69.2019.08.26.21.59.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 21:59:46 -0700 (PDT) To: Stafford Horne References: <20190827000745.19645-1-richard.henderson@linaro.org> <20190827000745.19645-7-richard.henderson@linaro.org> <20190827043624.GK24874@lianli.shorne-pla.net> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <38002440-429f-33cb-abe5-db3bb5efb562@linaro.org> Date: Mon, 26 Aug 2019 21:59:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190827043624.GK24874@lianli.shorne-pla.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: Re: [Qemu-devel] [PATCH 06/13] target/openrisc: Add VR2 and AVR special processor registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/26/19 9:36 PM, Stafford Horne wrote: >> /* Fields from here on are preserved across CPU reset. */ >> uint32_t vr; /* Version register */ >> + uint32_t vr2; /* Version register 2 */ >> + uint32_t avr; /* Architecture version register */ > > Do you need to update the serialization in machine.c? I don't think so, because these are invariant for the cpu type. It is not valid to migrate state to a different cpu. The VR, DMMUCFGR, IMMUCFGR entries that you pointed out wrt the previous patch wouldn't need to be in the serialization if they weren't already there. r~