From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
hpoussin@reactos.org, qemu-ppc@nongnu.org, atar4qemu@gmail.com,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 2/5] sun4m: use qdev properties instead of legacy m48t59_init() function
Date: Sat, 17 Oct 2020 11:42:00 +0200 [thread overview]
Message-ID: <387e845e-48b1-e78b-7d94-753fdeab4385@amsat.org> (raw)
In-Reply-To: <20201016182739.22875-3-mark.cave-ayland@ilande.co.uk>
On 10/16/20 8:27 PM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/sparc/sun4m.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
> index 54a2b2f9ef..a9bb60f2b2 100644
> --- a/hw/sparc/sun4m.c
> +++ b/hw/sparc/sun4m.c
> @@ -966,7 +966,13 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
> create_unimplemented_device("SUNW,sx", hwdef->sx_base, 0x2000);
> }
>
> - nvram = m48t59_init(slavio_irq[0], hwdef->nvram_base, 0, 0x2000, 1968, 8);
> + dev = qdev_new("sysbus-m48t08");
> + qdev_prop_set_int32(dev, "base-year", 1968);
> + s = SYS_BUS_DEVICE(dev);
> + sysbus_realize_and_unref(s, &error_fatal);
> + sysbus_connect_irq(s, 0, slavio_irq[0]);
> + sysbus_mmio_map(s, 0, hwdef->nvram_base);
> + nvram = NVRAM(dev);
While here, can you declare "Nvram *nvram"?
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> slavio_timer_init_all(hwdef->counter_base, slavio_irq[19], slavio_cpu_irq, smp_cpus);
>
>
next prev parent reply other threads:[~2020-10-17 9:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 18:27 [PATCH 0/5] m48t59: remove legacy init functions Mark Cave-Ayland
2020-10-16 18:27 ` [PATCH 1/5] m48t59-isa: remove legacy m48t59_init_isa() function Mark Cave-Ayland
2020-10-17 9:39 ` Philippe Mathieu-Daudé
2020-10-16 18:27 ` [PATCH 2/5] sun4m: use qdev properties instead of legacy m48t59_init() function Mark Cave-Ayland
2020-10-17 9:42 ` Philippe Mathieu-Daudé [this message]
2020-10-17 11:07 ` Mark Cave-Ayland
2020-10-16 18:27 ` [PATCH 3/5] sun4u: " Mark Cave-Ayland
2020-10-17 9:43 ` Philippe Mathieu-Daudé
2020-10-16 18:27 ` [PATCH 4/5] ppc405_boards: " Mark Cave-Ayland
2020-10-16 20:38 ` BALATON Zoltan via
2020-10-17 9:45 ` Philippe Mathieu-Daudé
2020-10-17 10:44 ` BALATON Zoltan via
2020-10-17 11:53 ` Mark Cave-Ayland
2020-10-17 11:16 ` Mark Cave-Ayland
2020-10-17 14:41 ` Artyom Tarasenko
2020-10-16 18:27 ` [PATCH 5/5] m48t59: remove " Mark Cave-Ayland
2020-10-17 9:53 ` Philippe Mathieu-Daudé
2020-10-17 11:19 ` Mark Cave-Ayland
2020-10-17 13:57 ` Philippe Mathieu-Daudé
2020-10-16 20:21 ` [PATCH 0/5] m48t59: remove legacy init functions Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=387e845e-48b1-e78b-7d94-753fdeab4385@amsat.org \
--to=f4bug@amsat.org \
--cc=atar4qemu@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).