From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D546C433DB for ; Fri, 22 Jan 2021 15:26:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF91823A84 for ; Fri, 22 Jan 2021 15:26:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF91823A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2yKI-0002xF-SP for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 10:26:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2yJH-0002HK-NS for qemu-devel@nongnu.org; Fri, 22 Jan 2021 10:25:15 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:53518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2yJD-00073G-Hh for qemu-devel@nongnu.org; Fri, 22 Jan 2021 10:25:15 -0500 Received: by mail-wm1-x334.google.com with SMTP id j18so4654116wmi.3 for ; Fri, 22 Jan 2021 07:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=RiuF4rrV+19okC6JPKaxK40vneYgcbkDjFesUwpbgzs=; b=eg1C7ZRQldZ5T7iMJEWTqDj76RB8js76TfsV16rM2XhmDCGIBJDH+vvUQ8fVCdMJN4 TULUQ8NbbIxOQCZdyIxyZjslYSr9YiL71aiGXJI3ZdqjGLU0WeI7cBs6FSyxgNVIK53p MHvXWq6i65q9ce5E2dmd/0GJCaYLzSuOyMSZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=RiuF4rrV+19okC6JPKaxK40vneYgcbkDjFesUwpbgzs=; b=kbpS4PnX9ugJBL7It3uRMGSQdAr5XLbT9R8k0KFE0s8vyHGYjdmfaNO5TPivzqdUj1 r21mN4kfKehGj3vbBK/cO5srSlIL0Co+1Zp9ek4rv8ad3HCFpAOqWeBLzeJOuSNjLCyS JYClT2TovwhnHbW1/GaOS29kar2jQPywtTbio/JYh4l09B4f+iWI21dx7N4jnlKn53ei ZDIVE/lZzM/Lee37cw/kXQBacGhztIqcNOubUFLykrrKjDxvuZ7fBcT9P0iOO0JYE3S9 vIhub5cb5yxwkqOGA0GjtbIN13vqCzvgdADiCwYX7nk8psV/k512/2J0t0HthjwEybMK SDqg== X-Gm-Message-State: AOAM533C6AaSiPWZ3OzXTKd0laIe39SJC9zyAulSfli2rORDTu9/R6Dv FQBs1xOqvbxsVVUDOVy+7RgFIQ== X-Google-Smtp-Source: ABdhPJwQQ+eGfpUcxCcO+3mSy2SxLibo5SL9peZ8AIpdOoxbd3DNK0FglZrDLbLZuJve2KyUN1HGsA== X-Received: by 2002:a1c:c257:: with SMTP id s84mr4459708wmf.146.1611329109691; Fri, 22 Jan 2021 07:25:09 -0800 (PST) Received: from ?IPv6:2001:8b0:aba:5f3c:6d8b:661b:50ff:3a78? ([2001:8b0:aba:5f3c:6d8b:661b:50ff:3a78]) by smtp.gmail.com with ESMTPSA id g18sm13000487wrw.61.2021.01.22.07.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 07:25:09 -0800 (PST) Message-ID: <39318d24a69728018ad015ea9899f4acaf7d39be.camel@linuxfoundation.org> Subject: Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type From: Richard Purdie To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , P J P , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Date: Fri, 22 Jan 2021 15:25:06 +0000 In-Reply-To: References: <20181012002217.2864-1-philmd@redhat.com> <20181012002217.2864-8-philmd@redhat.com> <3eefc179e8217ef0ec52080fc003796f70b112fe.camel@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=richard.purdie@linuxfoundation.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 2021-01-22 at 14:55 +0100, Philippe Mathieu-Daudé wrote: > Hi Prasad, Richard. > > On 1/22/21 12:52 PM, P J P wrote: > > +-- On Fri, 22 Jan 2021, Richard Purdie wrote --+ > > > If so can anyone point me at that change? > > > > > > I ask since CVE-2018-18438 is marked as affecting all qemu versions > > > (https://nvd.nist.gov/vuln/detail/CVE-2018-18438). > > > > > > If it was fixed, the version mask could be updated. If the fix wasn't deemed > > > worthwhile for some reason that is also fine and I can mark this one as such > > > in our system. I'm being told we only need one of the patches in this series > > > which I also don't believe as I suspect we either need the set or none of > > > them! > > > > > > Any info would be most welcome. > > > >   -> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02239.html > >   -> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02231.html > > > > * Yes, the type change fix had come up during patch reviews above, and this > >   series implemented the change. > > > > * Series is required IIUC, didn't realise it's not merged. > > Audit from Marc-André pointed that this is unlikely, we asked the > reporter for a reproducer and got not news, and eventually closed > this as NOTABUG (not even WONTFIX): > https://bugzilla.redhat.com/show_bug.cgi?id=1609015 I guessed there some resolution like this but couldn't find it thanks for the pointer. It's now clear in the archives and I can handle appropriately rejecting carrying those patches, thanks! Cheers, Richard