From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI
Date: Tue, 13 Aug 2019 19:54:16 +0200 [thread overview]
Message-ID: <39b21ab6-bf1b-69c1-bbea-fb6f1b637132@redhat.com> (raw)
In-Reply-To: <20190813133042.11683-1-stefanha@redhat.com>
On 8/13/19 3:30 PM, Stefan Hajnoczi wrote:
> The -usb section of the man page is not very clear on what exactly -usb
> does and fails to mention xHCI as a modern alternative (-device
> nec-usb-xhci).
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-options.hx | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9621e934c0..7d11c016d1 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1436,12 +1436,15 @@ STEXI
> ETEXI
>
> DEF("usb", 0, QEMU_OPTION_usb,
> - "-usb enable the USB driver (if it is not used by default yet)\n",
> + "-usb enable on-board USB host controller (if not enabled by default)\n",
> QEMU_ARCH_ALL)
> STEXI
> @item -usb
> @findex -usb
> -Enable the USB driver (if it is not used by default yet).
> +Enable USB emulation on machine types with an on-board USB host controller (if
> +not enabled by default). Note that on-board USB host controllers may not
> +support USB 3.0. In this case -device nec-usb-xhci can be used instead on
Should we maybe rather recommend qemu-xhci instead?
And please put the @option{} around the "-device *-xhci" here.
With @option:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-08-13 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:30 [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI Stefan Hajnoczi
2019-08-13 17:54 ` Thomas Huth [this message]
2019-08-14 13:23 ` Stefan Hajnoczi
2019-08-15 6:13 ` Gerd Hoffmann
2019-08-15 14:09 ` Stefan Hajnoczi
2019-08-14 9:58 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b21ab6-bf1b-69c1-bbea-fb6f1b637132@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).