From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1642C433E1 for ; Sat, 15 Aug 2020 15:59:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95F0323AA0 for ; Sat, 15 Aug 2020 15:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YkTBr86Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95F0323AA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6yav-0005kp-Tn for qemu-devel@archiver.kernel.org; Sat, 15 Aug 2020 11:59:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6ya2-0004bO-SQ; Sat, 15 Aug 2020 11:58:50 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:35583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6ya1-000115-9Z; Sat, 15 Aug 2020 11:58:50 -0400 Received: by mail-ej1-x641.google.com with SMTP id a26so13054299ejc.2; Sat, 15 Aug 2020 08:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=23ClA1zj5xFJ/0MPwFI0Fld8oSCrUIsEogBg4Ief7j4=; b=YkTBr86YEckUL1Q6GdC5yh5BlLbjrHsGM3RT4t3K4tzG390qdJBs8YnBfb32JHfash yJAmcV14RkNFPxZ5XL9xZzN81TkLZmbxKhWhWbuhvTFqkgo9xsNy6ZC64svjGZunQwst xWwCYwrCJSrZT/MOlKpgMaGjJlLWirnLhVT2JJLI/oyqGr0k07NoT+3aNTxqSVnJH2JT PUXMy7/UqUHfMuAVUFwArzEZqO8ob4Js2LeO3hmqV2sPscaoEYNAIUFMaryJEDwGJrRl vmy6m/+BrYGRcUO4/qVwAv/m8Z7WGQWnzBvsq58+JYiYNKWDiXHRGKInaZxGtQVBlwvx 2l5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=23ClA1zj5xFJ/0MPwFI0Fld8oSCrUIsEogBg4Ief7j4=; b=mMOWvA9ZMmnpPqtOEkC482z9QLHaZMZjFMQYJ+pTQuD3JhYwWom1VXB7pM1DZ9/Xqs xC8wpFvGNFjMF0Walx5wzY9BwKtILWa6LN6EMrJaNhTlm3GS1O9ZanHoGIefF0HXZkFQ NrMte0Kb5plNCaF+sNH+jtz73FsgvLxduVegK8RhTsx/cm0qbMt078rhafGSrQuEm62s 0FZtcQlucVEm1yJEZemTwF4zt4xkI7tNiIKtuDZ4fsJ0EIU4YG+wxslqZtCPLt8f6d2N flwcs5nfTrrXcSWkLpzZVLil7YLw+scTdEUV7HIvqHR2cagvre2menToBRu24kvRqzAh BEdA== X-Gm-Message-State: AOAM532jSA+9epSxCxXIae5lgYyI0SnVYRrV4GNlq7AF630BObGK/hch BVxJJ0G2z7to9y5FtlGkj1c6LetlHWU= X-Google-Smtp-Source: ABdhPJyCh2JMbov66bRCSzNwslYV0cujTQZRClFPFsv/CyvYv17PXy4cYPTjCJPM+yP+oPdO2Gskqg== X-Received: by 2002:adf:94c3:: with SMTP id 61mr5783672wrr.289.1597480706228; Sat, 15 Aug 2020 01:38:26 -0700 (PDT) Received: from [192.168.1.36] (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id u204sm20580087wmg.9.2020.08.15.01.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Aug 2020 01:38:25 -0700 (PDT) Subject: Re: [PATCH 08/18] hw/sd: sd: Correctly set the high capacity bit To: Bin Meng , Alistair Francis , Bastian Koppelmann , Palmer Dabbelt , Sagar Karandikar , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <1597423256-14847-1-git-send-email-bmeng.cn@gmail.com> <1597423256-14847-9-git-send-email-bmeng.cn@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <3b8ef426-77ce-d3b2-594b-045cae5ec94f@amsat.org> Date: Sat, 15 Aug 2020 10:38:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1597423256-14847-9-git-send-email-bmeng.cn@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Meng , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/14/20 6:40 PM, Bin Meng wrote: > From: Bin Meng > > Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports > capacity up to and including 2 GiB. > Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards") > Signed-off-by: Bin Meng > --- > > hw/sd/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 51f5900..5e7fc3f 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -313,7 +313,7 @@ static void sd_ocr_powerup(void *opaque) > /* card power-up OK */ > sd->ocr = FIELD_DP32(sd->ocr, OCR, CARD_POWER_UP, 1); > > - if (sd->size > 1 * GiB) { > + if (sd->size > 2 * GiB) { But you need to fix sd_set_csd() too, else this is incomplete. Thanks, Phil. > sd->ocr = FIELD_DP32(sd->ocr, OCR, CARD_CAPACITY, 1); > } > } >