From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282E5C433E0 for ; Fri, 19 Mar 2021 06:33:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8630A64E10 for ; Fri, 19 Mar 2021 06:33:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8630A64E10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lN8hh-0002CW-Cl for qemu-devel@archiver.kernel.org; Fri, 19 Mar 2021 02:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN8go-0001fs-0B for qemu-devel@nongnu.org; Fri, 19 Mar 2021 02:32:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN8gk-0006Xl-IM for qemu-devel@nongnu.org; Fri, 19 Mar 2021 02:32:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616135567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Jzy88wri+lkA1AVhp3wkJF7DH9xJXwfTqRRdKM8K0E=; b=fRwLdqUVPbcJHv5kndZbfvqO/zMHMiPcg2ZO+P3wfNtBujCzZ0jwibozogtTfoi4fzCm7L wI27hHoYZe3wPaiuBxVU80YZ4/jPF/QRPPkRvdwdKReG6HwkHGqu7F+4HECOiiooxpXs8A xb8wAUqGEwvE9Ws5R7jF3TIUuYtL9Eg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-0VkNmWw5MnCHQoS-Kt36Ig-1; Fri, 19 Mar 2021 02:32:45 -0400 X-MC-Unique: 0VkNmWw5MnCHQoS-Kt36Ig-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F372A100747E; Fri, 19 Mar 2021 06:32:43 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 377B960CCB; Fri, 19 Mar 2021 06:32:42 +0000 (UTC) Subject: Re: [PULL 5/5] m68k: add Virtual M68k Machine To: Max Reitz , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laurent Vivier , qemu-devel@nongnu.org, Qemu-block References: <20210315204226.3481044-1-laurent@vivier.eu> <20210315204226.3481044-6-laurent@vivier.eu> <2730eee0-6f1b-2139-f93c-6a0a64727e29@redhat.com> <905c797a-25c3-bb43-5946-54b28d9530c0@vivier.eu> <27c791b2-dcc0-6c98-d765-ac1b60b7af3d@vivier.eu> <0d55cabf-0fa0-f9fd-6436-de2e03422329@vivier.eu> <0b3cedb8-f40a-18fd-5030-a596afb9298d@redhat.com> <82f6dc3e-18bf-f90a-7e43-5568b319767c@redhat.com> From: Thomas Huth Message-ID: <3bcc22b2-eb25-b0a0-f47b-72c747ca6f0a@redhat.com> Date: Fri, 19 Mar 2021 07:32:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <82f6dc3e-18bf-f90a-7e43-5568b319767c@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.249, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/03/2021 18.28, Max Reitz wrote: [...] > From that it follows that I don’t see much use in testing specific devices > either.  Say there’s a platform that provides both virtio-pci and > virtio-mmio, the default (say virtio-pci) is fine for the iotests. I see > little value in testing virtio-mmio as well.  (Perhaps I’m short-sighted, > though.) That's a fair point. But still, if someone compiled QEMU only with a target that only provided virtio-mmio, the iotests should not fail when running "make check". To avoid that we continue playing whack-a-mole here in the future, maybe it would be better to restrict the iotests to the "main" targets only, e.g. modify check-block.sh so that the tests only run with x86, aarch64, s390x and ppc64 ? Thomas