From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187B3C49EAB for ; Tue, 5 Nov 2019 09:46:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E052420869 for ; Tue, 5 Nov 2019 09:46:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E052420869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRvPo-0000Kw-R8 for qemu-devel@archiver.kernel.org; Tue, 05 Nov 2019 04:46:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49632) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRvOb-0007xF-SE for qemu-devel@nongnu.org; Tue, 05 Nov 2019 04:45:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRvOa-00057D-Q0 for qemu-devel@nongnu.org; Tue, 05 Nov 2019 04:45:05 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:35833) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRvOa-00056e-GV for qemu-devel@nongnu.org; Tue, 05 Nov 2019 04:45:04 -0500 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MryCb-1i6w7X1Cy5-00nwAt; Tue, 05 Nov 2019 10:45:02 +0100 Subject: Re: [PATCH v2 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat To: Richard Henderson , qemu-devel@nongnu.org References: <20191025113921.9412-1-richard.henderson@linaro.org> <20191025113921.9412-3-richard.henderson@linaro.org> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <3cee7c2f-79b4-d142-49ce-2d1dac2eff59@vivier.eu> Date: Tue, 5 Nov 2019 10:45:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191025113921.9412-3-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:gwqbX8xXhbFMrunhb16YQuJ9IK4Za8x+j0Cn/NyFT9BGQji1O7J wMHaFRu4UvvFQME3bZf9zhN655vWWPrUefnRHwGW2+0f7xeWRNMq2AXgvSJ+vN/N/mggl04 BxgQtyP6L5dOADBtZNqrR34s2KLjtkOCLX7QHXf/hvki3HnUmrmvq6Ikky/j4aZfZiLzulO C9EDw05sDG1WE96sfxhxA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ruIsvgyTU80=:6cKKHVFP7LiTg4iBmuAn7F byE2axmLBIIl9fpuIWocUQKNb6VFhTcGWg7eG2j8mbQofspk/vahIpQOPycxHA1VPvzRW2nK4 YeKp//SYIMel0t2WPC5waPekcLkCeqdhkM2k8SB3qH1jCOvOjCMaCy3k3dVqoa25xOvkqA5ND yAtnppPDS/QtVViyg7cA4apxAZ7kOimjK2lOxwgbtz8tW2AO+SG1XjDgnK3XiVvOxcG+jPGZk rkiLzaBu1l44mcCuOVwdU4tXqqaahMiXB3UzrGBsi0H45zeFl4Kv7vyGqE+bHxbkN7cEQ00L+ tX+csom7YXIsESNFNzW03yMLWLl8DWVS5vTl+v79I2rJcYAze6QE3VmwPXG2qZQFiIcJU4z/S 00FAUCzoT9Mhp1parrhMdTVT0SEMrLYfkGM8XRcHOVGWMWGfI94HcDacj+N0n7ZzqLhyh2F7k P4W7Xk1luAIWLcu1ZtllJ7z820FymnyWfB9cSfe1aDtR9gZd9h5+0v78tRw6ZjLXwzcwO2CTs 2VX/lF1up8oJTFqW32+qA8/1mFYmH/kpvUJ0zv+mDE8DooNsj5wz+hpFg+hc5z0IXr6BQQeFo Uq7436EcSQtPavbn2XoTNsrfXE7shauPfVaexsoDEp/leCJJZbZwLtCtGz5p8FfVMXTfCnCsa /06J0EBEC4gXi89d1khd5u9KUU6TGHqHjSDq6UnFz1eoF4Cp0xwl0iWC+R9WX01almdg7LiqC X1eqTx2QfO3gw1BO92eJhgwYPZEMRjLq4YaPcwU8lUtU+FZZbm7JFODAmx9NGZ6uPQf+zhw54 3C9rhSgtpbRIiRbYLPAKkJ93sP40EtklzDjC2mnVn2ORmJOfgZgtW2caTTIDCZOrIuDlenwpl vbxo2E2lzcPejj1zzpAmIrle8vYUHp69qkpbBtB+U= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.133 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 25/10/2019 à 13:39, Richard Henderson a écrit : > The error indicator for this syscall is -1, not 0. > > Reviewed-by: Laurent Vivier > Signed-off-by: Richard Henderson > --- > tests/tcg/multiarch/linux-test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c > index fa4243fc04..673d7c8a1c 100644 > --- a/tests/tcg/multiarch/linux-test.c > +++ b/tests/tcg/multiarch/linux-test.c > @@ -503,8 +503,9 @@ static void test_shm(void) > > shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); > ptr = shmat(shmid, NULL, 0); > - if (!ptr) > + if (ptr == (void *)-1) { > error("shmat"); > + } > > memset(ptr, 0, SHM_SIZE); > > Applied to my linux-user branch. Thanks, Laurent