From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392BDC433E1 for ; Tue, 25 Aug 2020 18:41:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144942071E for ; Tue, 25 Aug 2020 18:41:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RXk52AXH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144942071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAdsX-0000vL-D3 for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 14:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAdrU-0000FH-5C for qemu-devel@nongnu.org; Tue, 25 Aug 2020 14:40:00 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:37746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAdrS-0000dZ-FV for qemu-devel@nongnu.org; Tue, 25 Aug 2020 14:39:59 -0400 Received: by mail-pg1-x543.google.com with SMTP id g33so7433145pgb.4 for ; Tue, 25 Aug 2020 11:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=JofeZzJ5SExg9SUh7gqUsyQBbdBpgvVivJ1TorSzG9A=; b=RXk52AXHDt/Njtutv9ZVE4oSFP+ovKxZFi7wxg+Ug43LoNLh4TiXCpdfLHtuE9VLUA nlZf0wPX8p3TtUG65fKD0fmakc6J7AKdosAFMKfqoOJmWxNizBIPuNTpVQTZ1wEaPBNU mOqdaTpD5RT2/ZvYbZTCMIg+re5Mp7GVj07qSUNmzD81Mz8HUmch/IzWHAESgJkmI08m xwLP4iwICdH3tUCVyFUSI5gDywMBLZcjuUhzmeiE2dfOqhUF765WMc4vNS1Ld/X5OmA2 MSBTQMaLZiYghoyFqfVOjXKmqyOdY3fAUs84R8x1XD1T1FhGTVdXBZdHPdRoGZIl2szF vqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JofeZzJ5SExg9SUh7gqUsyQBbdBpgvVivJ1TorSzG9A=; b=ajzbu0AAzgfRUHeXztibDniyrfcrVJJ9fn2o7FAVLzc406jge/u4xRc46DnRH8Fr0j BugGfW9HTjNHlhG6VRuYoFKEJ9QCY6kd71iEJuhrlu4aswPLl2X6hSmE8ngS9130s9Jo weYqqX56EaBjYcwAUtt3YSxe+Z88f/KGbSxDj0PFDmh/nibhHYMoDBZ9bkVjEHDAmST+ BKo3FwgQ6upzqA3fb14w4qBi3no+AFMhOURKd7E1QoUjEsHTh0l/b37AVBi/Iol5bQw+ lEgBuNDotzLRUcXOmkDHLvg7+LFsG1xCsRjKfihqd0LU9AtOICkqCpQfET6qosmXVk6Q +DQA== X-Gm-Message-State: AOAM532vIfkbKh7KI/jwmEgbZA9FO9rob11bMIATyZVsWzFP5K/NHEL0 Bdf+uzIDz4hwvvuw/CseQKbZICZ1eZOR2g== X-Google-Smtp-Source: ABdhPJzzm/7X+ot6FfPhfpfu2SkaOz580synt9XodY70H0u06p1g1olWFy+zOi+Fx0o/wVzTQPpiZQ== X-Received: by 2002:a17:902:8f8f:: with SMTP id z15mr8596549plo.221.1598380796372; Tue, 25 Aug 2020 11:39:56 -0700 (PDT) Received: from [192.168.81.79] (h216-228-167-147.bendor.dedicated.static.tds.net. [216.228.167.147]) by smtp.gmail.com with ESMTPSA id q34sm97937pgl.28.2020.08.25.11.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2020 11:39:55 -0700 (PDT) Subject: Re: [PATCH 10/22] target/arm: Implement VFP fp16 VCMP To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20200824142934.20850-1-peter.maydell@linaro.org> <20200824142934.20850-11-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <3cfb93cb-6a50-a229-c9f5-b8cb96dfa675@linaro.org> Date: Tue, 25 Aug 2020 11:39:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200824142934.20850-11-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.602, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/24/20 7:29 AM, Peter Maydell wrote: > Implement fp16 version of VCMP. > > Signed-off-by: Peter Maydell > --- > target/arm/helper.h | 2 ++ > target/arm/vfp.decode | 2 ++ > target/arm/vfp_helper.c | 15 +++++++------ > target/arm/translate-vfp.c.inc | 39 ++++++++++++++++++++++++++++++++++ > 4 files changed, 51 insertions(+), 7 deletions(-) Same comments re the helper types. Otherwise, Reviewed-by: Richard Henderson r~