From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [PATCH 2/3] target/arm: Fix reported EL for mte_check_fail
Date: Fri, 9 Oct 2020 12:10:16 +0100 [thread overview]
Message-ID: <3e2f2248-8810-bf72-a498-91fa65eeded9@arm.com> (raw)
In-Reply-To: <20201008162155.161886-3-richard.henderson@linaro.org>
On 10/8/20 5:21 PM, Richard Henderson wrote:
> The reporting in AArch64.TagCheckFail only depends on PSTATE.EL,
> and not the AccType of the operation. There are two guest
> visible problems that affect LDTR and STTR because of this:
>
> (1) Selecting TCF0 vs TCF1 to decide on reporting,
> (2) Report "data abort same el" not "data abort lower el".
>
> Reported-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> target/arm/mte_helper.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c
> index 734cc5ca67..153bd1e9df 100644
> --- a/target/arm/mte_helper.c
> +++ b/target/arm/mte_helper.c
> @@ -525,14 +525,10 @@ static void mte_check_fail(CPUARMState *env, uint32_t desc,
> reg_el = regime_el(env, arm_mmu_idx);
> sctlr = env->cp15.sctlr_el[reg_el];
>
> - switch (arm_mmu_idx) {
> - case ARMMMUIdx_E10_0:
> - case ARMMMUIdx_E20_0:
> - el = 0;
> + el = arm_current_el(env);
> + if (el == 0) {
> tcf = extract64(sctlr, 38, 2);
> - break;
> - default:
> - el = reg_el;
> + } else {
> tcf = extract64(sctlr, 40, 2);
> }
>
>
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-10-09 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 16:21 [PATCH 0/3] target/arm: MTE fixes Richard Henderson
2020-10-08 16:21 ` [PATCH 1/3] target/arm: Remove redundant mmu_idx lookup Richard Henderson
2020-10-08 16:32 ` Philippe Mathieu-Daudé
2020-10-09 11:12 ` Vincenzo Frascino
2020-10-08 16:21 ` [PATCH 2/3] target/arm: Fix reported EL for mte_check_fail Richard Henderson
2020-10-09 11:10 ` Vincenzo Frascino [this message]
2020-10-08 16:21 ` [PATCH 3/3] target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11 Richard Henderson
2020-10-09 11:10 ` Vincenzo Frascino
2020-10-09 11:11 ` [PATCH 0/3] target/arm: MTE fixes Vincenzo Frascino
2020-10-20 14:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2f2248-8810-bf72-a498-91fa65eeded9@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).