From: Max Reitz <mreitz@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
integration@gluster.org, sheepdog@lists.wpkg.org,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Jason Dillaman <dillaman@redhat.com>,
Jeff Cody <codyprime@gmail.com>, Stefan Weil <sw@weilnetz.de>,
Peter Lieven <pl@kamp.de>,
"Richard W.M. Jones" <rjones@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Liu Yuan <namei.unix@gmail.com>
Subject: Re: [PATCH 0/2] Fix the generic image creation code
Date: Thu, 26 Mar 2020 14:38:13 +0100 [thread overview]
Message-ID: <3f1e924d-7f52-87f2-8363-4658fdf833d8@redhat.com> (raw)
In-Reply-To: <e5855331-05a9-c828-5bdd-e2d06e0352a9@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1263 bytes --]
On 26.03.20 13:23, Max Reitz wrote:
> On 26.03.20 02:12, Maxim Levitsky wrote:
>> The recent patches from Max Reitz allowed some block drivers to not
>> provide the .bdrv_co_create_opts and still allow qemu-img to
>> create/format images as long as the image is already existing
>> (that is the case with various block storage drivers like nbd/iscsi/nvme, etc)
>>
>> However it was found out that some places in the code depend on the
>> .bdrv_co_create_opts/.create_opts to be != NULL to decide if to allow
>> image creation.
>>
>> To avoid adding failback code to all these places, just make generic failback
>> code be used by the drivers that need it, so that for outside user, there
>> is no diffirence if failback was used or not.
>>
>> Best regards,
>> Maxim Levitsky
>>
>> Maxim Levitsky (2):
>> block: pass BlockDriver reference to the .bdrv_co_create
>> block: trickle down the fallback image creation function use to the
>> block drivers
>
> Thanks, fixed the function parameter alignment, moved the declarations
> from block.h into block_int.h, and applied the series to my block branch:
(And the spelling fixes suggested by Eric)
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
> Max
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-26 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 1:12 [PATCH 0/2] Fix the generic image creation code Maxim Levitsky
2020-03-26 1:12 ` [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create Maxim Levitsky
2020-03-26 13:18 ` Eric Blake
2020-03-26 13:22 ` Maxim Levitsky
2020-03-26 13:27 ` Eric Blake
2020-03-26 1:12 ` [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers Maxim Levitsky
2020-03-26 11:20 ` Max Reitz
2020-03-26 13:20 ` Eric Blake
2020-03-26 13:28 ` Kevin Wolf
2020-03-26 13:35 ` Eric Blake
2020-03-26 13:39 ` Max Reitz
2020-03-26 13:30 ` Maxim Levitsky
2020-03-26 10:55 ` [PATCH 0/2] Fix the generic image creation code Denis V. Lunev
2020-03-26 12:23 ` Max Reitz
2020-03-26 13:38 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f1e924d-7f52-87f2-8363-4658fdf833d8@redhat.com \
--to=mreitz@redhat.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=dillaman@redhat.com \
--cc=fam@euphon.net \
--cc=integration@gluster.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).