From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF2FC49ED7 for ; Fri, 13 Sep 2019 11:07:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7AF320830 for ; Fri, 13 Sep 2019 11:07:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7AF320830 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8jQP-0000jn-M8 for qemu-devel@archiver.kernel.org; Fri, 13 Sep 2019 07:07:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42257) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8jPi-0000DD-KR for qemu-devel@nongnu.org; Fri, 13 Sep 2019 07:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8jPh-00006V-K3 for qemu-devel@nongnu.org; Fri, 13 Sep 2019 07:06:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55004) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8jPf-00004r-7x; Fri, 13 Sep 2019 07:06:51 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58A123E2D3; Fri, 13 Sep 2019 11:06:50 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-116-81.ams2.redhat.com [10.36.116.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF1991001944; Fri, 13 Sep 2019 11:06:45 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , Kevin Wolf References: <20190816153015.447957-1-vsementsov@virtuozzo.com> <20190816153015.447957-4-vsementsov@virtuozzo.com> <20190913100146.GC8312@dhcp-200-226.str.redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <40620e71-a5e0-b955-d310-eef14ad3871c@redhat.com> Date: Fri, 13 Sep 2019 13:06:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mdPZ1laWu24ImHTjsEJUfhRN088fLjQQB" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 13 Sep 2019 11:06:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_part X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Denis Lunev , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , "armbru@redhat.com" , "stefanha@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mdPZ1laWu24ImHTjsEJUfhRN088fLjQQB Content-Type: multipart/mixed; boundary="DvTIa2oW5sSKlonEvcScE5AiDOxYyjfeA"; protected-headers="v1" From: Max Reitz To: Vladimir Sementsov-Ogievskiy , Kevin Wolf Cc: "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , "armbru@redhat.com" , "eblake@redhat.com" , Denis Lunev , "stefanha@redhat.com" Message-ID: <40620e71-a5e0-b955-d310-eef14ad3871c@redhat.com> Subject: Re: [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_part References: <20190816153015.447957-1-vsementsov@virtuozzo.com> <20190816153015.447957-4-vsementsov@virtuozzo.com> <20190913100146.GC8312@dhcp-200-226.str.redhat.com> In-Reply-To: --DvTIa2oW5sSKlonEvcScE5AiDOxYyjfeA Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13.09.19 12:53, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2019 13:01, Kevin Wolf wrote: >> Am 16.08.2019 um 17:30 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Further patch will run partial requests of iterations of >>> qcow2_co_preadv in parallel for performance reasons. To prepare for >>> this, separate part which may be parallelized into separate function >>> (qcow2_co_preadv_task). >>> >>> While being here, also separate encrypted clusters reading to own >>> function, like it is done for compressed reading. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> Reviewed-by: Max Reitz >>> --- >>> qapi/block-core.json | 2 +- >>> block/qcow2.c | 205 +++++++++++++++++++++++-----------------= --- >>> 2 files changed, 111 insertions(+), 96 deletions(-) >>> >>> diff --git a/qapi/block-core.json b/qapi/block-core.json >>> index 0d43d4f37c..dd80aa11db 100644 >>> --- a/qapi/block-core.json >>> +++ b/qapi/block-core.json >>> @@ -3266,7 +3266,7 @@ >>> 'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev'= , >>> 'pwritev_zero', 'pwritev_done', 'empty_image_prepare', >>> 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters', >>> - 'cor_write', 'cluster_alloc_space', 'none'] } >>> + 'cor_write', 'cluster_alloc_space', 'none', 'read_encryp= ted'] } >> >> What's the point of this new blkdebug event? >> >> Obviously, read_aio for an encrypted image must mean a read of encrypt= ed >> data. The same image can never trigger both read_aio and >> read_encrypted, so why do we need to distinguish them as two different= >> events? >> >=20 > Seems I just done it looking at qcow2_co_preadv_compressed.. >=20 > Anyway, I think you are right, so, I don't mind if Max drops this new e= vent > and use read_aio in his branch, or I can resend the series or send a fo= llow-up, > whichever you prefer. Should I squash this in? diff --git a/qapi/block-core.json b/qapi/block-core.json index d9ae73a43c..e6edd641f1 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3264,7 +3264,7 @@ 'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev', 'pwritev_zero', 'pwritev_done', 'empty_image_prepare', 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters', - 'cor_write', 'cluster_alloc_space', 'none', 'read_encrypted'= ] } + 'cor_write', 'cluster_alloc_space', 'none'] } ## # @BlkdebugIOType: diff --git a/block/qcow2.c b/block/qcow2.c index b5fe014b20..c07ce84d54 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2001,7 +2001,7 @@ qcow2_co_preadv_encrypted(BlockDriverState *bs, return -ENOMEM; } - BLKDBG_EVENT(bs->file, BLKDBG_READ_ENCRYPTED); + BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO); ret =3D bdrv_co_pread(s->data_file, file_cluster_offset + offset_into_cluster(s, offset), bytes, buf, 0); --DvTIa2oW5sSKlonEvcScE5AiDOxYyjfeA-- --mdPZ1laWu24ImHTjsEJUfhRN088fLjQQB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl17eEMACgkQ9AfbAGHV z0C40Qf/cEjxZyqg6YFJIvd68gOrH80NMU/J35/gikGoS16P82cbFarh6hK2eHBz iYsFmC7QE8YPg1tTDeP/5KnKoK0AymdlAEkXVSpekEaV2XN3WiwLlyDb34ZnWEXU 0iHlg4UAsHLPaXpSXcdbrnbWEV9YYErKB9o1N7/8MyjxxgHexJ9xz/g+PI3zYOKp 7bJcgZZMPZY/W7Rbfy2kady6u3E2iZHVGvUEUtG9Zj8OEqAajIyWE6wvxEMcA7WF iYwb6BlAtq5mhRZ3hfTAXZSgkA95Yvd8EiTPcJGtD+zXFr9hIT9l51zefs2e3DzI KPhEveFmdamXLj9KMqFgtmNwPBhgzA== =i5B/ -----END PGP SIGNATURE----- --mdPZ1laWu24ImHTjsEJUfhRN088fLjQQB--