From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG
Date: Thu, 29 Aug 2019 20:04:47 +0200 [thread overview]
Message-ID: <427b3a07-b428-fca4-a6ed-ba0d663d6a83@redhat.com> (raw)
In-Reply-To: <64061664-f79f-b074-8fec-fea24594d5df@linaro.org>
On 8/23/19 7:04 PM, Richard Henderson wrote:
> On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote:
>> @@ -2535,6 +2544,7 @@ static const ARMCPUInfo arm_cpus[] = {
>> { .name = "arm1176", .initfn = arm1176_initfn },
>> { .name = "arm11mpcore", .initfn = arm11mpcore_initfn },
>> { .name = "cortex-m0", .initfn = cortex_m0_initfn,
>> +#endif
>> .class_init = arm_v7m_class_init },
>> { .name = "cortex-m3", .initfn = cortex_m3_initfn,
>> .class_init = arm_v7m_class_init },
>
> Ifdef is misplaced. This shouldn't even compile without CONFIG_TCG.
What a shame... I hope I messed this due to a failed rebase...
> Also, m-profile shouldn't work with kvm either, so I think the endif should go
> below cortex-m33.
Obviously.
next prev parent reply other threads:[~2019-08-29 18:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 13:58 [Qemu-devel] [PATCH 0/4] Support disabling TCG on ARM (part 2) Philippe Mathieu-Daudé
2019-08-23 13:58 ` [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG Philippe Mathieu-Daudé
2019-08-23 17:04 ` Richard Henderson
2019-08-29 18:04 ` Philippe Mathieu-Daudé [this message]
2019-08-23 13:58 ` [Qemu-devel] [PATCH 2/4] target/arm: Restrict R and M profiles " Philippe Mathieu-Daudé
2019-08-23 17:06 ` Richard Henderson
2019-08-23 13:58 ` [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM Philippe Mathieu-Daudé
2019-08-23 14:28 ` Thomas Huth
2019-08-29 18:19 ` Philippe Mathieu-Daudé
2019-08-30 5:35 ` Thomas Huth
2019-08-23 17:12 ` Richard Henderson
2019-08-29 18:08 ` Philippe Mathieu-Daudé
2019-08-23 13:58 ` [Qemu-devel] [PATCH 4/4] RFC target/arm: Do not build A/M-profile " Philippe Mathieu-Daudé
2019-08-23 17:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427b3a07-b428-fca4-a6ed-ba0d663d6a83@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).