From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 09/26] tests/qtests: clean-up and fix leak in generic_fuzz
Date: Mon, 26 Jun 2023 10:06:44 +0200 [thread overview]
Message-ID: <42b497a0-e234-64db-e845-1c37b67839fc@linaro.org> (raw)
In-Reply-To: <20230623122100.1640995-10-alex.bennee@linaro.org>
On 6/23/23 14:20, Alex Bennée wrote:
> An update to the clang tooling detects more issues with the code
> including a memory leak from the g_string_new() allocation. Clean up
> the code with g_autoptr and use ARRAY_SIZE while we are at it.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qtest/fuzz/generic_fuzz.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index c525d22951..a4841181cc 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -954,17 +954,14 @@ static void register_generic_fuzz_targets(void)
> .crossover = generic_fuzz_crossover
> });
>
> - GString *name;
> + g_autoptr(GString) name = g_string_new("");
> const generic_fuzz_config *config;
>
> - for (int i = 0;
> - i < sizeof(predefined_configs) / sizeof(generic_fuzz_config);
> - i++) {
> + for (int i = 0; i < ARRAY_SIZE(predefined_configs); i++) {
> config = predefined_configs + i;
> - name = g_string_new("generic-fuzz");
> - g_string_append_printf(name, "-%s", config->name);
> + g_string_printf(name, "generic-fuzz-%s", config->name);
> fuzz_add_target(&(FuzzTarget){
> - .name = name->str,
> + .name = g_strdup(name->str),
> .description = "Predefined generic-fuzz config.",
> .get_init_cmdline = generic_fuzz_predefined_config_cmdline,
> .pre_fuzz = generic_pre_fuzz,
This is
.name = g_strconcat("generic-fuzz-", config->name, NULL),
without the extra GString or printf stuff.
r~
next prev parent reply other threads:[~2023-06-26 8:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 12:20 [PATCH 00/26] maintainer omnibus: testing, fuzz, plugins, documentation Alex Bennée
2023-06-23 12:20 ` [PATCH 01/26] gitlab: explicit set artifacts publishing criteria Alex Bennée
2023-06-26 7:58 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 02/26] gitlab: ensure coverage job also publishes meson log Alex Bennée
2023-06-26 7:59 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 03/26] gitlab: reduce testing scope of check-gcov Alex Bennée
2023-06-26 7:59 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 04/26] docs/devel: remind developers to run CI container pipeline when updating images Alex Bennée
2023-06-23 12:20 ` [PATCH 05/26] tests/tcg: add mechanism to handle plugin arguments Alex Bennée
2023-06-23 12:20 ` [PATCH 06/26] qemu-keymap: use modern name for Arabic keymap Alex Bennée
2023-06-23 12:23 ` Peter Maydell
2023-06-23 12:20 ` [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-06-23 12:25 ` Peter Maydell
2023-06-26 20:21 ` Alex Bennée
2023-06-23 12:20 ` [PATCH 08/26] scripts/oss-fuzz: add a suppression for keymap Alex Bennée
2023-06-26 8:02 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 09/26] tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée
2023-06-26 8:06 ` Richard Henderson [this message]
2023-06-23 12:20 ` [PATCH 10/26] tests/docker: add test-fuzz Alex Bennée
2023-06-23 12:20 ` [PATCH 11/26] Makefile: add lcitool-refresh to UNCHECKED_GOALS Alex Bennée
2023-06-23 15:10 ` Philippe Mathieu-Daudé
2023-06-23 12:20 ` [PATCH 12/26] tests/lcitool: update to latest version Alex Bennée
2023-06-26 8:08 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 13/26] tests/lcitool: Bump fedora container versions Alex Bennée
2023-06-26 8:09 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 14/26] tests/lcitool: add an explicit gcc-native package Alex Bennée
2023-06-26 8:10 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 15/26] tests/lcitool: introduce qemu-minimal Alex Bennée
2023-06-26 8:14 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 16/26] tests/docker: convert riscv64-cross to lcitool Alex Bennée
2023-06-26 8:16 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 17/26] tests/avocado: update firmware to enable sbsa-ref/max Alex Bennée
2023-06-23 15:14 ` Philippe Mathieu-Daudé
2023-06-23 12:20 ` [PATCH 18/26] plugins: force slow path when plugins instrument memory ops Alex Bennée
2023-06-23 12:20 ` [PATCH 19/26] plugins: fix memory leak while parsing options Alex Bennée
2023-06-26 8:24 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 20/26] plugins: update lockstep to use g_memdup2 Alex Bennée
2023-06-26 8:25 ` Richard Henderson
2023-06-23 12:20 ` [PATCH 21/26] docs/devel: add some front matter to the devel index Alex Bennée
2023-06-23 12:20 ` [PATCH 22/26] include/migration: mark vmstate_register() as a legacy function Alex Bennée
2023-06-23 12:20 ` [PATCH 23/26] include/hw/qdev-core: fixup kerneldoc annotations Alex Bennée
2023-06-23 12:20 ` [PATCH 24/26] docs/devel/qom.rst: Correct code style Alex Bennée
2023-06-23 12:20 ` [PATCH 25/26] docs/devel: split qom-api reference into new file Alex Bennée
2023-06-23 12:21 ` [PATCH 26/26] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-06-26 13:27 ` Paolo Bonzini
2023-06-26 13:39 ` Alex Bennée
2023-06-26 15:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b497a0-e234-64db-e845-1c37b67839fc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).