From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D069C32750 for ; Tue, 13 Aug 2019 16:49:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D67F120842 for ; Tue, 13 Aug 2019 16:49:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D67F120842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxZz5-0002gD-4Y for qemu-devel@archiver.kernel.org; Tue, 13 Aug 2019 12:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60590) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxZyZ-0001qB-6Y for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxZyY-0000HZ-BH for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:48:47 -0400 Received: from 7.mo3.mail-out.ovh.net ([46.105.57.200]:52868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxZyY-0000GW-5z for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:48:46 -0400 Received: from player796.ha.ovh.net (unknown [10.108.57.72]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 25817222F8B for ; Tue, 13 Aug 2019 18:48:43 +0200 (CEST) Received: from kaod.org (lfbn-1-2240-157.w90-76.abo.wanadoo.fr [90.76.60.157]) (Authenticated sender: clg@kaod.org) by player796.ha.ovh.net (Postfix) with ESMTPSA id C1B308BBD9B1; Tue, 13 Aug 2019 16:48:38 +0000 (UTC) To: Peter Maydell References: <20190813164420.9829-1-clg@kaod.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <43eb577e-27a7-de43-93f5-b4f2ae8f3b70@kaod.org> Date: Tue, 13 Aug 2019 18:48:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Ovh-Tracer-Id: 16855566031047134165 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddviedguddttdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.57.200 Subject: Re: [Qemu-devel] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Satheesh Rajendran , qemu-ppc , QEMU Developers , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13/08/2019 18:46, Peter Maydell wrote: > On Tue, 13 Aug 2019 at 17:44, C=C3=A9dric Le Goater wrot= e: >> >> If an IRQ is allocated and not configured, such as a MSI requested by >> a PCI driver, it can be saved in its default state and possibly later >> on restored using the same state. If not initially MASKED, KVM will >> try to find a matching priority/target tuple for the interrupt and >> fail to restore the VM because 0/0 is not a valid target. >> >> When allocating a IRQ number, the EAS should be set to a sane default = : >> VALID and MASKED. >> >> Reported-by: Satheesh Rajendran >> Signed-off-by: C=C3=A9dric Le Goater >> --- >> >> David, this fixes a "virsh save/restore" issue in certain configurati= ons >> of CPU topology which never showed up before :/ >> >> Peter, I was busy on a KVM/passthru issue and lacked the time to >> investigate all ... you decide. >=20 > rc5 has been tagged so this is definitely too late for 4.1. This is nothing too invasive which will be difficult to backport. Thanks, C.=20