From: "Cédric Le Goater" <clg@kaod.org>
To: Rashmica Gupta <rashmica.g@gmail.com>, peter.maydell@linaro.org
Cc: andrew@aj.id.au, qemu-arm@nongnu.org, qemu-devel@nongnu.org,
joel@jms.id.au
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model
Date: Wed, 14 Aug 2019 14:46:17 +0200 [thread overview]
Message-ID: <440d3bd1-57fd-20eb-dce4-3d61d7163b8e@kaod.org> (raw)
In-Reply-To: <20190730054501.32727-1-rashmica.g@gmail.com>
On 30/07/2019 07:44, Rashmica Gupta wrote:
> There are a couple of things I'm not confident about here:
> - what should be in init vs realize?
> - should the irq state be in vmstate?
> - is there a better way to do composition of classes (patch 3)?
You can not do twice :
obj = object_new(TYPE_ASPEED_GPIO "-ast2600");
in aspeed_2600_gpio_realize(). This feels wrong.
Let's see if we can instantiate two GPIO devices with different types
under the AST2600 SoC instead.
Thanks,
C.
>
> v3:
> - didn't have each gpio set up as an irq
> - now can't access set AC on ast2400 (only exists on ast2500)
> - added ast2600 implementation (patch 3)
> - renamed a couple of variables for clarity
>
>
> v2: Addressed Andrew's feedback, added debounce regs, renamed get/set to
> read/write to minimise confusion with a 'set' of registers.
>
> Rashmica Gupta (3):
> hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500
> aspeed: add a GPIO controller to the SoC
> hw/gpio: Add in AST2600 specific implementation
>
> hw/arm/aspeed_soc.c | 17 +
> hw/gpio/Makefile.objs | 1 +
> hw/gpio/aspeed_gpio.c | 1103 +++++++++++++++++++++++++++++++++
> include/hw/arm/aspeed_soc.h | 3 +
> include/hw/gpio/aspeed_gpio.h | 91 +++
> 5 files changed, 1215 insertions(+)
> create mode 100644 hw/gpio/aspeed_gpio.c
> create mode 100644 include/hw/gpio/aspeed_gpio.h
>
prev parent reply other threads:[~2019-08-14 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 5:44 [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model Rashmica Gupta
2019-07-30 5:44 ` [Qemu-devel] [PATCH v3 1/3] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500 Rashmica Gupta
2019-08-06 13:57 ` Peter Maydell
2019-08-14 7:20 ` Rashmica Gupta
2019-07-30 5:45 ` [Qemu-devel] [PATCH v3 2/3] aspeed: add a GPIO controller to the SoC Rashmica Gupta
2019-07-30 5:45 ` [Qemu-devel] [PATCH v3 3/3] hw/gpio: Add in AST2600 specific implementation Rashmica Gupta
2019-08-13 7:31 ` Alexey Kardashevskiy
2019-08-14 7:21 ` Rashmica Gupta
2019-08-06 14:08 ` [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model Peter Maydell
2019-08-14 12:46 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440d3bd1-57fd-20eb-dce4-3d61d7163b8e@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).